Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #524 #525

Merged
merged 5 commits into from
Sep 12, 2022
Merged

fix for #524 #525

merged 5 commits into from
Sep 12, 2022

Conversation

shipyy
Copy link
Contributor

@shipyy shipyy commented Sep 12, 2022

previous pr fix for this in hindsifghted i believe was missing a few more things (til)

  • fix for wrong PERSONAL record query
  • fix for wrong position to send new record forward

@shipyy
Copy link
Contributor Author

shipyy commented Sep 12, 2022

i have not tested it (cannot atm) if someone else could confirm it does in fact work would be awesome! (:

--added time difference between old and new server style record to printed phrase
--actually fixed issues(?)
@Synert
Copy link
Contributor

Synert commented Sep 12, 2022

Style times are saving properly, but records are not being output in the Discord or printing the record message ( beat the <style> map record). This is also occurring for the first time set

'g_fOldStyleRecordMapTime' isn't being set anywhere

Copy link
Contributor

@Synert Synert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in surftimer.phrases.txt - '{4,s}' -> '{4:s}'. Other changes confirmed working on Thunderdome

@shipyy
Copy link
Contributor Author

shipyy commented Sep 12, 2022

hopefully all good now (:

Copy link
Contributor

@Synert Synert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working as expected on Thunderdome

@Bara Bara merged commit d92c60a into surftimer:dev Sep 12, 2022
Bara pushed a commit that referenced this pull request Sep 13, 2022
* --fix style records/forwards

* --added oldtime var for styles
--added time difference between old and new server style record to printed phrase
--actually fixed issues(?)

* --missing set values for new var

* --missing indexation

* --wrong format
dPexxIAM added a commit that referenced this pull request Nov 14, 2022
* Test server should based on dev branch

* Allow pr tests against the dev branch

* Upload build packages for dev branch too

* Remove artifact after one month

* remove old code, wait 2 frames before setting velocity to 0 (#518)

* Update fresh_install.sql (#519)

Fixed errors.

* Add missing ck_replays table (#520)

* Fix version in error message (#521)

* --wrong value on check (#522)

* fix for #524 (#525)

* --fix style records/forwards

* --added oldtime var for styles
--added time difference between old and new server style record to printed phrase
--actually fixed issues(?)

* --missing set values for new var

* --missing indexation

* --wrong format

* Rename some files for clarity for updating tables

* Add semicolons (#528)

* Use LogStackTrace instead of LogError (#530)

Usage of sizeof instead of hardcoded size

* Add radar images to DownloadTable (#529)

* add radar images to download table

* remove colon from readme

* add surf load screens to readme

* Add EU test server to workflow

* Add EU test server to README.md

* Fix chat processor for our commands (#533)

* Log query times (#531)

* Hello World

* Hello World

* Print each query time into server console while startup

* Log query times into logs/surftimer/<map>.log logs

* Update globals.sp (#536)

if database name is greater than 32 then will get following error

[SM] Exception reported: More/Less then 1 rows? RowCount: 0, Table: ck_bonus, Column: runtime
[SM] Blaming: SurfTimer.smx
[SM] Call stack trace:
[SM]   [0] SetFailState
[SM]   [1] Line 241, surftimer/db/updater.sp::SQLCheckDataType

* Increase name length (#534)

* Increase name length from 32 to 128

* Increase name size per updater

* Add missing tables

* Update VARCHAR size in fresh_install.sql

* Skip error check to prevent invalid error

* 128 -> 64

* practice mode changes (#539)

* practice mode changes

* remove timer function

* forgot this timer seperates stuff into a million different functions :)

* add mapper names to ck_maptier (#538)

* add mapper names to ck_maptier

* use translation

* readme: improve installation + requirements docs (#537)

* readme: improve installation + requirements docs

* readme: EndTouchFix note update

* readme: EndTouchFix note update

Co-authored-by: dPexxIAM <38400978+dPexxIAM@users.noreply.github.com>
Co-authored-by: Jacob Christiansen <kin.jacob.chr@gmail.com>
Co-authored-by: shipyy <70631212+shipyy@users.noreply.github.com>
Co-authored-by: T <74899888+tslashd@users.noreply.github.com>
Co-authored-by: Kyle <kyle@kxnrl.com>
Co-authored-by: 8guawong <8guawong@gmail.com>
Co-authored-by: Markus <mark@saiko.tech>
dPexxIAM added a commit that referenced this pull request Feb 10, 2023
* Test server should based on dev branch

* Allow pr tests against the dev branch

* Upload build packages for dev branch too

* Remove artifact after one month

* remove old code, wait 2 frames before setting velocity to 0 (#518)

* Update fresh_install.sql (#519)

Fixed errors.

* Add missing ck_replays table (#520)

* Fix version in error message (#521)

* --wrong value on check (#522)

* fix for #524 (#525)

* --fix style records/forwards

* --added oldtime var for styles
--added time difference between old and new server style record to printed phrase
--actually fixed issues(?)

* --missing set values for new var

* --missing indexation

* --wrong format

* Rename some files for clarity for updating tables

* Add semicolons (#528)

* Use LogStackTrace instead of LogError (#530)

Usage of sizeof instead of hardcoded size

* Add radar images to DownloadTable (#529)

* add radar images to download table

* remove colon from readme

* add surf load screens to readme

* Add EU test server to workflow

* Add EU test server to README.md

* Fix chat processor for our commands (#533)

* Log query times (#531)

* Hello World

* Hello World

* Print each query time into server console while startup

* Log query times into logs/surftimer/<map>.log logs

* Update globals.sp (#536)

if database name is greater than 32 then will get following error

[SM] Exception reported: More/Less then 1 rows? RowCount: 0, Table: ck_bonus, Column: runtime
[SM] Blaming: SurfTimer.smx
[SM] Call stack trace:
[SM]   [0] SetFailState
[SM]   [1] Line 241, surftimer/db/updater.sp::SQLCheckDataType

* Increase name length (#534)

* Increase name length from 32 to 128

* Increase name size per updater

* Add missing tables

* Update VARCHAR size in fresh_install.sql

* Skip error check to prevent invalid error

* 128 -> 64

* practice mode changes (#539)

* practice mode changes

* remove timer function

* forgot this timer seperates stuff into a million different functions :)

* add mapper names to ck_maptier (#538)

* add mapper names to ck_maptier

* use translation

* readme: improve installation + requirements docs (#537)

* readme: improve installation + requirements docs

* readme: EndTouchFix note update

* readme: EndTouchFix note update

* Fix SQL Error while creating ck_maptiermappers table

* or equal to prestige_rank (#541)

* Fix LoadDefaultTitle (only load the first one) (#543)

* Fix LoadDefaultTitle (only load the first one)

* If the title is enforced, break the loop

Co-authored-by: Ismael Semmar Galvez <isgalvez24@gmail.com>

* Missing mapper name argument for Map Info (#547)

* fix /mi

* revert and use g_szMapperName

* chore: small code cleanup (#545)

* fixes non-ranked players being kicked from server when ck_prestige_rank = 0 (#544)

* #506 (#548)

* fresh_install update (#551)

* increase cplimit from 37 to 100 (#552)

---------

Co-authored-by: dPexxIAM <38400978+dPexxIAM@users.noreply.github.com>
Co-authored-by: Jacob Christiansen <kin.jacob.chr@gmail.com>
Co-authored-by: shipyy <70631212+shipyy@users.noreply.github.com>
Co-authored-by: T <74899888+tslashd@users.noreply.github.com>
Co-authored-by: Kyle <kyle@kxnrl.com>
Co-authored-by: 8guawong <8guawong@gmail.com>
Co-authored-by: Markus <mark@saiko.tech>
Co-authored-by: Ismael Semmar Galvez <30930942+Ism1tha@users.noreply.github.com>
Co-authored-by: Ismael Semmar Galvez <isgalvez24@gmail.com>
Co-authored-by: Charles <63302440+Sarrus1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants