Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License is not found using the Github API #1002

Open
3 tasks done
paolomainardi opened this issue Jul 22, 2024 · 0 comments · May be fixed by #1003
Open
3 tasks done

License is not found using the Github API #1002

paolomainardi opened this issue Jul 22, 2024 · 0 comments · May be fixed by #1003

Comments

@paolomainardi
Copy link

What piece of documentation is affected?

The license

What part(s) of the article would you like to see updated?

The license file

Additional Information

I was fetching some data from here: https://api.github.com/repos/superagent-ai/superagent/license
I found that the license is not correctly identified:

{
  "name": "LICENSE",
  "path": "LICENSE",
  "sha": "2cff8db0fb4d90347f4eeb64e58d22c1c99b99e2",
  "size": 947,
  "url": "https://api.github.com/repos/superagent-ai/superagent/contents/LICENSE?ref=main",
  "html_url": "https://github.com/superagent-ai/superagent/blob/main/LICENSE",
  "git_url": "https://api.github.com/repos/superagent-ai/superagent/git/blobs/2cff8db0fb4d90347f4eeb64e58d22c1c99b99e2",
  "download_url": "https://github.com/superagent-ai/superagent/main/LICENSE",
  "type": "file",
  "content": "IyBMaWNlbnNlCgojIyBNSVQgTGljZW5zZQoKQ29weXJpZ2h0IChjKSAyMDIz\nIElzbWFpbCBQZWxhc2V5ZWQKClBlcm1pc3Npb24gaXMgaGVyZWJ5IGdyYW50\nZWQsIGZyZWUgb2YgY2hhcmdlLCB0byBhbnkgcGVyc29uIG9idGFpbmluZyBh\nIGNvcHkgb2YgdGhpcyBzb2Z0d2FyZSBhbmQgYXNzb2NpYXRlZCBkb2N1bWVu\ndGF0aW9uIGZpbGVzICh0aGUgIlNvZnR3YXJlIiksIHRvIHVzZSwgY29weSwg\nbW9kaWZ5LCBtZXJnZSwgcHVibGlzaCwgZGlzdHJpYnV0ZSwgc3VibGljZW5z\nZSwgYW5kL29yIHNlbGwgY29waWVzIG9mIHRoZSBTb2Z0d2FyZSwgc3ViamVj\ndCB0byB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnM6CgoxLiBUaGUgYWJvdmUg\nY29weXJpZ2h0IG5vdGljZSBhbmQgdGhpcyBwZXJtaXNzaW9uIG5vdGljZSBz\naGFsbCBiZSBpbmNsdWRlZCBpbiBhbGwgY29waWVzIG9yIHN1YnN0YW50aWFs\nIHBvcnRpb25zIG9mIHRoZSBTb2Z0d2FyZS4KClRIRSBTT0ZUV0FSRSBJUyBQ\nUk9WSURFRCAiQVMgSVMsIiBXSVRIT1VUIFdBUlJBTlRZIE9GIEFOWSBLSU5E\nLCBFWFBSRVNTIE9SIElNUExJRUQsIElOQ0xVRElORyBCVVQgTk9UIExJTUlU\nRUQgVE8gVEhFIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZLCBGSVRO\nRVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRSwgQU5EIE5PTklORlJJTkdF\nTUVOVC4KCjIuIEluIG5vIGV2ZW50IHNoYWxsIHRoZSBhdXRob3JzIG9yIGNv\ncHlyaWdodCBob2xkZXJzIGJlIGxpYWJsZSBmb3IgYW55IGNsYWltLCBkYW1h\nZ2VzLCBvciBvdGhlciBsaWFiaWxpdHksIHdoZXRoZXIgaW4gYW4gYWN0aW9u\nIG9mIGNvbnRyYWN0LCB0b3J0LCBvciBvdGhlcndpc2UsIGFyaXNpbmcgZnJv\nbSwgb3V0IG9mLCBvciBpbiBjb25uZWN0aW9uIHdpdGggdGhlIFNvZnR3YXJl\nIG9yIHRoZSB1c2Ugb3Igb3RoZXIgZGVhbGluZ3MgaW4gdGhlIFNvZnR3YXJl\nLgo=\n",
  "encoding": "base64",
  "_links": {
    "self": "https://api.github.com/repos/superagent-ai/superagent/contents/LICENSE?ref=main",
    "git": "https://api.github.com/repos/superagent-ai/superagent/git/blobs/2cff8db0fb4d90347f4eeb64e58d22c1c99b99e2",
    "html": "https://github.com/superagent-ai/superagent/blob/main/LICENSE"
  },
  "license": {
    "key": "other",
    "name": "Other",
    "spdx_id": "NOASSERTION",
    "url": null,
    "node_id": "MDc6TGljZW5zZTA="
  }
}

I think that can be fixed just by adding a license identifier: // SPDX-License-Identifier: MIT License to the license file.

Acknowledgements

  • My issue title is concise, descriptive, and in title casing.
  • I have searched the existing issues to make sure this feature has not been requested yet.
  • I have provided enough information for the maintainers to understand and evaluate this request.
paolomainardi added a commit to paolomainardi/superagent that referenced this issue Jul 22, 2024
@paolomainardi paolomainardi linked a pull request Jul 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant