Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add definition and voting rules of -contrib repositories #707

Merged
merged 4 commits into from
Oct 3, 2024

Commits on Sep 24, 2024

  1. docs: add definition and voting rules of -contrib repositories

    This PR adds the concept of `-contrib` repositories to the governance
    rules of Substrait. To that aim, the following changes are made:
    
    * Mention that there is a distinction between "core" and `-contrib`
      repositories in the introduction of the Substrait project. Those
      definitions are used in what follows.
    * Say that contributors can have write access to `-contrib`
      repositories. This allows people to make changes to those repositories
      without being promoted to committers.
    * Clarify that committers are people who have write access to "core"
      repositories. This makes clear that having write access to a
      `-contrib` repository doesn't make someone a committer.
    * Add a voting rule for `-contrib` repositories: Any contributor other
      than the proposer can vote. This is a pretty low bar but it ensures
      that one other human being with some relationship to the project
      approves the change.
    
    Signed-off-by: Ingo Müller <ingomueller@google.com>
    ingomueller-net committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    503ee6e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c6f345c View commit details
    Browse the repository at this point in the history
  3. Apply changes suggested by @jacques-n and others.

    * Apply @jacques-n's suggestion on how to give write access to
      `-contrib` repositories.
    * Apply @jacques-n's suggestion on committer rights in `-contrib`
      repositories.
    * Apply @jacques-n's suggestion on voting rules related to `-contrib`
      repositories.
    * Fix typo in "contributor."
    ingomueller-net committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    a41b3c1 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Update site/docs/governance.md

    Co-authored-by: Weston Pace <weston.pace@gmail.com>
    jacques-n and westonpace authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    1f5e092 View commit details
    Browse the repository at this point in the history