Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add precision timestamp datetime fn variants #666

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

vbarua
Copy link
Member

@vbarua vbarua commented Jul 19, 2024

No description provided.

@vbarua
Copy link
Member Author

vbarua commented Jul 19, 2024

This PR adds functions variants for PrecisionTimestamp and PrecisionTimestampTZ to aid in migrating off of the the deprecated Timestamp and TimestampTZ types.

Not all functions can be given variants easily. For example for

  -
    name: "add"
      - args:
          - name: x
            value: date
          - name: y
            value: interval_day
        return: timestamp

We cannot add a precision_timestamp variant because it would only differ in the output type. Choosing not to handle these for now.

@vbarua
Copy link
Member Author

vbarua commented Jul 19, 2024

I've loaded these into substrait-java successfully.

@jacques-n jacques-n merged commit 60c93d2 into main Aug 1, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants