Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify row_number as 1-based #722

Closed
tokoko opened this issue Oct 8, 2024 · 1 comment
Closed

Specify row_number as 1-based #722

tokoko opened this issue Oct 8, 2024 · 1 comment

Comments

@tokoko
Copy link
Contributor

tokoko commented Oct 8, 2024

row_number function doesn't specify whether the numbers start at 1 or 0. While most engines do start at 1, I think it's still worth being explicit here. ibis for example normalizes row numbers to start at 0 instead of 1.
@vbarua vbarua mentioned this issue Oct 8, 2024
Merged
vbarua added a commit that referenced this issue Oct 8, 2024
@vbarua
feat: specify row_number start (#722) (#723)
a0388ff 
row_number should start counting rows at 1
@vbarua
Copy link
Member

vbarua commented Oct 8, 2024

The spec has been updated!

@vbarua vbarua closed this as completed Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vbarua @tokoko