Skip to content

Commit

Permalink
fix(ci): check MSRV in CI, fix clippy warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
mbrobbel committed May 13, 2024
1 parent 904f9ce commit bdca13b
Show file tree
Hide file tree
Showing 3 changed files with 30 additions and 2 deletions.
28 changes: 28 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,34 @@ name: Test
on: [push, pull_request]

jobs:
msrv:
name: Minimum Supported Rust Version
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0
submodules: recursive
- uses: dtolnay/rust-toolchain@1.62
id: rust-toolchain
- uses: actions/cache@v4
with:
path: |
~/.cargo/bin/
~/.cargo/registry/index/
~/.cargo/registry/cache/
~/.cargo/git/db/
target/
key: ${{ runner.os }}-cargo-${{ steps.rust-toolchain.outputs.cachekey }}-check-${{ hashFiles('**/Cargo.toml') }}
restore-keys: |
${{ runner.os }}-cargo-${{ steps.rust-toolchain.outputs.cachekey }}-check-
${{ runner.os }}-cargo-${{ steps.rust-toolchain.outputs.cachekey }}-
${{ runner.os }}-cargo-
- run: cargo check --all-targets --all-features
- run: cargo clippy --all-targets --all-features -- -Dwarnings
- run: cargo test --all-targets --all-features
- run: cargo test --doc --all-features

check:
name: Check
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
name = "substrait"
version = "0.32.0"
edition = "2021"
rust-version = "1.60"
rust-version = "1.62"
description = "Cross-Language Serialization for Relational Algebra"
documentation = "https://docs.rs/substrait"
readme = "README.md"
Expand Down
2 changes: 1 addition & 1 deletion src/text.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
#![allow(
clippy::clone_on_copy,
clippy::derivable_impls,
clippy::to_string_trait_impl,
clippy::uninlined_format_args,
unused_variables
)]

//! Generated types for text-based definitions.

// https://github.com/oxidecomputer/typify/issues/245
include!(concat!(env!("OUT_DIR"), "/substrait_text.rs"));

#[cfg(test)]
Expand Down

0 comments on commit bdca13b

Please sign in to comment.