[Feature] Add a hero component
#99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Liax
requested review from
titouanmathis,
Guillaume-meta,
perruche and
antoine4livre
Export SizeUnchanged@studiometa/ui
|
Codecov Report
@@ Coverage Diff @@
## develop #99 +/- ##
===========================================
- Coverage 26.64% 26.55% -0.10%
===========================================
Files 46 46
Lines 1141 1145 +4
Branches 211 214 +3
===========================================
Hits 304 304
- Misses 771 775 +4
Partials 66 66
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
perruche
reviewed
Dec 6, 2022
|
suggestion Add a block to insert breadcrumbs |
…tes instead of just classes. Add conditions to the elements. Add the figure componant. Add the possibility to have mutliple CTA
titouanmathis
requested changes
Dec 9, 2022
There was a problem hiding this comment.
Hey @Liax, great job on the update!
Note: don't be overwhelmed by the multiple comments I left, this component is looking really good and promising 👍
This should simplify getting started with the project.
Liax
requested review from
titouanmathis,
Guilm and
perruche
and removed request for
Guilm
titouanmathis
requested changes
Jan 3, 2023
Guilm
reviewed
Jan 17, 2023
| { class: ['hero__image'] } | ||
| ) | ||
| }) | ||
| %} |
There was a problem hiding this comment.
we need some additionnal params, see below :
{% set image =
image
|default({})
|merge({
src: image.src,
width: image.width,
height: image.height,
alt: image.alt,
attr: merge_html_attributes(
image.attr ?? null,
{ class: 'absolute inset-0' },
{ class: 'hero__image' }
)
})
%}
titouanmathis
requested changes
Jan 20, 2023
There was a problem hiding this comment.
One small adjustment to the CHANGELOG and we will be able to merge this! Well done @Liax!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
First draft of a hero component
To do:
...