-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Action: add support for multiple events #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Export Size@studiometa/ui
Unchanged@studiometa/ui
|
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## develop #299 +/- ##
===========================================
+ Coverage 77.42% 77.77% +0.35%
===========================================
Files 91 92 +1
Lines 3171 3222 +51
Branches 278 288 +10
===========================================
+ Hits 2455 2506 +51
Misses 716 716
Flags with carried forward coverage won't be shown. Click here to find out more. β View full report in Codecov by Sentry. |
titouanmathis
force-pushed
the
feature/action-multiple-events
branch
from
September 20, 2024 12:59
09d2219
to
83148a5
Compare
titouanmathis
force-pushed
the
feature/action-multiple-events
branch
from
September 20, 2024 13:12
83148a5
to
12bab33
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
#298
β Type of change
π Description
This PR refactors the
Action
component to add support for multiple events. The existing API is still available, but we can now use new attributes to configure multiple events.Event, targets and effect can now be configured with a single attribute with the following pattern:
Test it in the playground.
π Checklist