Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add support for automatic update of all Data... component on change #281

Merged
merged 4 commits into from
Aug 1, 2024

Conversation

titouanmathis
Copy link
Contributor

@titouanmathis titouanmathis commented Aug 1, 2024

πŸ”— Linked issue

#279

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Before this PR, setting the value of a DataBind instance in JavaScript with instance.value = newValue did not update all other instances. The dispatch of a new value to all related instances was only happening when an input event was triggered on a DataModel component.

This PR adds automatic dispatch of a new value set on a DataBind component.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.
  • I have updated the changelog.

Copy link

github-actions bot commented Aug 1, 2024

Export Size

@studiometa/ui

Name Size Diff
DataComputed 811 B +43 B (+5.60%) πŸ”Ί
DataBind 671 B +31 B (+4.84%) πŸ”Ί
DataModel 745 B +34 B (+4.78%) πŸ”Ί
DataEffect 778 B +33 B (+4.43%) πŸ”Ί
ATOMS 5.14 kB +32 B (+0.63%) πŸ”Ί
ALL 12.68 kB +30 B (+0.24%) πŸ”Ί
Unchanged

@studiometa/ui

Name Size Diff
AbstractPrefetch 411 B -
AbstractScrollAnimation 461 B -
AbstractSliderChild 2.46 kB -
Accordion 1.06 kB -
AccordionItem 1.02 kB -
Action 648 B -
AnchorNav 615 B -
AnchorNavLink 480 B -
AnchorNavTarget 207 B -
AnchorScrollTo 243 B -
animationScrollWithEase 272 B -
CircularMarquee 339 B -
Cursor 665 B -
Draggable 327 B -
Figure 694 B -
FigureTwicpics 1.15 kB -
FigureVideo 983 B -
FigureVideoTwicpics 1.48 kB -
Frame 1.68 kB -
FrameAnchor 201 B -
FrameForm 198 B -
FrameTarget 777 B -
LargeText 492 B -
LazyInclude 418 B -
loadImage 694 B -
Menu 1.38 kB -
MenuBtn 230 B -
MenuList 943 B -
Modal 898 B -
ModalWithTransition 1.01 kB -
MOLECULES 7.12 kB -
ORGANISMS 1.74 kB -
Panel 1.25 kB -
PrefetchWhenOver 468 B -
PrefetchWhenVisible 480 B -
PRIMITIVES 632 B -
ScrollAnimation 513 B -
ScrollAnimationChild 650 B -
ScrollAnimationChildWithEase 851 B -
ScrollAnimationParent 712 B -
ScrollAnimationWithEase 711 B -
ScrollReveal 622 B -
Sentinel 217 B -
Slider 2.26 kB -
SliderBtn 2.62 kB -
SliderCount 2.49 kB -
SliderDots 2.7 kB -
SliderDrag 353 B -
SliderItem 733 B -
SliderProgress 2.54 kB -
Sticky 859 B -
TableOfContent 742 B -
TableOfContentAnchor 550 B -
Tabs 625 B -
Target 189 B -
Transition 387 B -

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 34.02%. Comparing base (9cdc8a3) to head (1299d1c).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #281      +/-   ##
===========================================
+ Coverage    33.84%   34.02%   +0.17%     
===========================================
  Files           60       60              
  Lines         1492     1496       +4     
  Branches       263      278      +15     
===========================================
+ Hits           505      509       +4     
- Misses         909      986      +77     
+ Partials        78        1      -77     
Flag Coverage Ξ”
unittests 34.02% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@titouanmathis titouanmathis merged commit 409b2b3 into develop Aug 1, 2024
14 checks passed
@titouanmathis titouanmathis deleted the feature/databind-dispatch-value branch August 1, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant