-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Improve the Action component #261
Conversation
Export Size@studiometa/ui
Unchanged@studiometa/ui
|
649ed9f
to
c7a8abd
Compare
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## develop #261 +/- ##
===========================================
+ Coverage 32.26% 33.53% +1.26%
===========================================
Files 59 60 +1
Lines 1469 1485 +16
Branches 260 262 +2
===========================================
+ Hits 474 498 +24
+ Misses 994 909 -85
- Partials 1 78 +77
Flags with carried forward coverage won't be shown. Click here to find out more. β View full report in Codecov by Sentry. |
82f1172
to
618582a
Compare
Fix component name resolution The name options can be overriden by user defined options on a component, so we use the name defined in the static config of the component instead.
357376e
to
8bde142
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good for me, what about creating a decorator to replace the name of a component in the static config ?
CustomTransition: withName(Transition, 'CustomTransition')
The @studiometa/js-toolkit package already exports a |
π Linked issue
#258
β Type of change
π Description
This PR implements the suggestion from #258.
See the docs preview for usage and examples.
.stop
,.prevent
,.capture
,.once
, and.passive
π Checklist