Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Improve the Action component #261

Merged
merged 17 commits into from
Jul 29, 2024
Merged

Conversation

titouanmathis
Copy link
Contributor

@titouanmathis titouanmathis commented Jul 16, 2024

πŸ”— Linked issue

#258

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR implements the suggestion from #258.

See the docs preview for usage and examples.

  • Add support for event modifiers: .stop, .prevent, .capture, .once, and .passive

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.
  • I have updated the changelog.

Copy link

github-actions bot commented Jul 16, 2024

Export Size

@studiometa/ui

Name Size Diff
Target 189 B +189 B (+100.00%) πŸ”Ί
Action 648 B +140 B (+27.56%) πŸ”Ί
ATOMS 5.06 kB +148 B (+3.01%) πŸ”Ί
ALL 12.6 kB +127 B (+1.02%) πŸ”Ί
Unchanged

@studiometa/ui

Name Size Diff
AbstractPrefetch 411 B -
AbstractScrollAnimation 461 B -
AbstractSliderChild 2.46 kB -
Accordion 1.06 kB -
AccordionItem 1.02 kB -
AnchorNav 615 B -
AnchorNavLink 480 B -
AnchorNavTarget 207 B -
AnchorScrollTo 243 B -
animationScrollWithEase 272 B -
CircularMarquee 339 B -
Cursor 665 B -
DataBind 632 B -
DataComputed 760 B -
DataEffect 737 B -
DataModel 660 B -
Draggable 327 B -
Figure 694 B -
FigureTwicpics 1.15 kB -
FigureVideo 983 B -
FigureVideoTwicpics 1.48 kB -
Frame 1.68 kB -
FrameAnchor 201 B -
FrameForm 198 B -
FrameTarget 777 B -
LargeText 492 B -
LazyInclude 418 B -
loadImage 694 B -
Menu 1.38 kB -
MenuBtn 230 B -
MenuList 943 B -
Modal 898 B -
ModalWithTransition 1.01 kB -
MOLECULES 7.12 kB -
ORGANISMS 1.74 kB -
Panel 1.25 kB -
PrefetchWhenOver 468 B -
PrefetchWhenVisible 480 B -
PRIMITIVES 632 B -
ScrollAnimation 513 B -
ScrollAnimationChild 650 B -
ScrollAnimationChildWithEase 851 B -
ScrollAnimationParent 712 B -
ScrollAnimationWithEase 711 B -
ScrollReveal 622 B -
Sentinel 217 B -
Slider 2.26 kB -
SliderBtn 2.62 kB -
SliderCount 2.49 kB -
SliderDots 2.7 kB -
SliderDrag 353 B -
SliderItem 733 B -
SliderProgress 2.54 kB -
Sticky 859 B -
TableOfContent 742 B -
TableOfContentAnchor 550 B -
Tabs 625 B -
Transition 387 B -

@titouanmathis titouanmathis force-pushed the feature/action branch 3 times, most recently from 649ed9f to c7a8abd Compare July 16, 2024 14:52
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 33.53%. Comparing base (c5f5268) to head (64788c8).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #261      +/-   ##
===========================================
+ Coverage    32.26%   33.53%   +1.26%     
===========================================
  Files           59       60       +1     
  Lines         1469     1485      +16     
  Branches       260      262       +2     
===========================================
+ Hits           474      498      +24     
+ Misses         994      909      -85     
- Partials         1       78      +77     
Flag Coverage Ξ”
unittests 33.53% <100.00%> (+1.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@titouanmathis titouanmathis force-pushed the feature/action branch 2 times, most recently from 82f1172 to 618582a Compare July 16, 2024 21:25
@titouanmathis titouanmathis marked this pull request as ready for review July 17, 2024 07:45
Copy link
Contributor

@antoine4livre antoine4livre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me, what about creating a decorator to replace the name of a component in the static config ?

CustomTransition: withName(Transition, 'CustomTransition')

@titouanmathis
Copy link
Contributor Author

All good for me, what about creating a decorator to replace the name of a component in the static config ?

CustomTransition: withName(Transition, 'CustomTransition')

The @studiometa/js-toolkit package already exports a withName decorator, but it is not yet documented.

@titouanmathis titouanmathis merged commit 530dce9 into develop Jul 29, 2024
14 checks passed
@titouanmathis titouanmathis deleted the feature/action branch July 29, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants