Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add advanced placeholder configuration for FigureTwicpics #251

Merged
merged 6 commits into from
Jul 3, 2024

Conversation

titouanmathis
Copy link
Contributor

πŸ”— Linked issue

No issue.

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR adds support for using an object for the twic_placeholder parameter in order to apply advanced transformation for the image placeholder of the FigureTwicpics component.

{# Will display a lighter version of the image with its quality degraded to 5 #}

{% include '@ui/atoms/Figure/FigureTwicpics.twig' with {
  twic_domain: 'org.twic.pics',
  twic_placeholder: {
    quality_max: 5,
  },
} %}

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.
  • I have updated the changelog.

Copy link

github-actions bot commented Jul 3, 2024

Export Size

Unchanged

@studiometa/ui

Name Size Diff
AbstractPrefetch 411 B -
AbstractScrollAnimation 461 B -
AbstractSliderChild 2.46 kB -
Accordion 1.06 kB -
AccordionItem 1.02 kB -
Action 508 B -
ALL 11.91 kB -
AnchorNav 615 B -
AnchorNavLink 480 B -
AnchorNavTarget 207 B -
AnchorScrollTo 243 B -
animationScrollWithEase 272 B -
ATOMS 4.3 kB -
CircularMarquee 339 B -
Cursor 665 B -
Draggable 327 B -
Figure 694 B -
FigureTwicpics 1.15 kB -
FigureVideo 983 B -
FigureVideoTwicpics 1.48 kB -
Frame 1.68 kB -
FrameAnchor 201 B -
FrameForm 198 B -
FrameTarget 777 B -
LargeText 492 B -
LazyInclude 418 B -
loadImage 694 B -
Menu 1.38 kB -
MenuBtn 230 B -
MenuList 943 B -
Modal 908 B -
ModalWithTransition 1.02 kB -
MOLECULES 7.12 kB -
ORGANISMS 1.74 kB -
Panel 1.26 kB -
PrefetchWhenOver 468 B -
PrefetchWhenVisible 480 B -
PRIMITIVES 632 B -
ScrollAnimation 513 B -
ScrollAnimationChild 650 B -
ScrollAnimationChildWithEase 851 B -
ScrollAnimationParent 712 B -
ScrollAnimationWithEase 711 B -
ScrollReveal 622 B -
Sentinel 217 B -
Slider 2.26 kB -
SliderBtn 2.62 kB -
SliderCount 2.49 kB -
SliderDots 2.7 kB -
SliderDrag 353 B -
SliderItem 733 B -
SliderProgress 2.54 kB -
Sticky 859 B -
TableOfContent 742 B -
TableOfContentAnchor 550 B -
Tabs 625 B -
Transition 387 B -

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 27.88%. Comparing base (06aa188) to head (8d755fb).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #251   +/-   ##
========================================
  Coverage    27.88%   27.88%           
========================================
  Files           54       54           
  Lines         1370     1370           
  Branches       241      245    +4     
========================================
  Hits           382      382           
+ Misses         988      911   -77     
- Partials         0       77   +77     
Flag Coverage Ξ”
unittests 27.88% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@titouanmathis titouanmathis force-pushed the feature/figure-twicpics-advanced-placeholder branch 2 times, most recently from 57624a8 to 8ec460e Compare July 3, 2024 12:24
@titouanmathis titouanmathis force-pushed the feature/figure-twicpics-advanced-placeholder branch from 8ec460e to 8d755fb Compare July 3, 2024 12:31
@titouanmathis titouanmathis merged commit ed08987 into develop Jul 3, 2024
14 checks passed
@titouanmathis titouanmathis deleted the feature/figure-twicpics-advanced-placeholder branch July 3, 2024 12:56
@titouanmathis titouanmathis mentioned this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant