Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add support for post request in Frame component #194

Merged
merged 6 commits into from
Apr 17, 2024

Conversation

perruche
Copy link
Contributor

@perruche perruche commented Apr 2, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Add support for POST request for the Frame component.
Based on current implementation on a project.
Not really convinced this is the my robust way of doing it. i'm also wondering if this is going to work onWindowPopstate.
Requesting review to have feedback before processing to documentation, tests, etc

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.
  • I have updated the changelog.

@perruche perruche added the enhancement New feature or request label Apr 2, 2024
Copy link

github-actions bot commented Apr 2, 2024

Export Size

@studiometa/ui

Name Size Diff
Frame 1.68 kB +66 B (+4.08%) πŸ”Ί
ORGANISMS 1.74 kB +61 B (+3.63%) πŸ”Ί
ALL 11.91 kB +49 B (+0.41%) πŸ”Ί
Unchanged

@studiometa/ui

Name Size Diff
AbstractPrefetch 411 B -
AbstractScrollAnimation 461 B -
AbstractSliderChild 2.46 kB -
Accordion 1.06 kB -
AccordionItem 1.02 kB -
Action 508 B -
AnchorNav 615 B -
AnchorNavLink 480 B -
AnchorNavTarget 207 B -
AnchorScrollTo 243 B -
animationScrollWithEase 272 B -
ATOMS 4.3 kB -
CircularMarquee 339 B -
Cursor 665 B -
Draggable 327 B -
Figure 694 B -
FigureTwicpics 1.15 kB -
FigureVideo 983 B -
FigureVideoTwicpics 1.48 kB -
FrameAnchor 201 B -
FrameForm 198 B -
FrameTarget 777 B -
LargeText 492 B -
LazyInclude 418 B -
loadImage 694 B -
Menu 1.38 kB -
MenuBtn 230 B -
MenuList 943 B -
Modal 908 B -
ModalWithTransition 1.02 kB -
MOLECULES 7.12 kB -
Panel 1.26 kB -
PrefetchWhenOver 468 B -
PrefetchWhenVisible 480 B -
PRIMITIVES 632 B -
ScrollAnimation 513 B -
ScrollAnimationChild 650 B -
ScrollAnimationChildWithEase 851 B -
ScrollAnimationParent 712 B -
ScrollAnimationWithEase 711 B -
ScrollReveal 622 B -
Sentinel 217 B -
Slider 2.26 kB -
SliderBtn 2.62 kB -
SliderCount 2.49 kB -
SliderDots 2.7 kB -
SliderDrag 353 B -
SliderItem 733 B -
SliderProgress 2.54 kB -
Sticky 859 B -
TableOfContent 742 B -
TableOfContentAnchor 550 B -
Tabs 625 B -
Transition 387 B -

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 28.14%. Comparing base (8177111) to head (a31f8e3).

❗ Current head a31f8e3 differs from pull request most recent head 4c712c8. Consider uploading reports for the commit 4c712c8 to get more accurate results

Files Patch % Lines
packages/ui/organisms/Frame/Frame.ts 0.00% 12 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #194      +/-   ##
===========================================
+ Coverage    28.04%   28.14%   +0.10%     
===========================================
  Files           54       49       -5     
  Lines         1362     1254     -108     
  Branches       253      243      -10     
===========================================
- Hits           382      353      -29     
+ Misses         980      832     -148     
- Partials         0       69      +69     
Flag Coverage Ξ”
unittests 28.14% <0.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link
Contributor

@titouanmathis titouanmathis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

packages/ui/organisms/Frame/Frame.ts Show resolved Hide resolved
packages/ui/organisms/Frame/Frame.ts Show resolved Hide resolved
@perruche perruche self-assigned this Apr 3, 2024
@perruche
Copy link
Contributor Author

perruche commented Apr 3, 2024

Shall i add something more to this PR ? Try to add a bit of explanation on how the component work, does it seems right ?

@titouanmathis titouanmathis force-pushed the feature/add-post-support-to-frame branch from a31f8e3 to 4c712c8 Compare April 17, 2024 14:43
@titouanmathis titouanmathis merged commit 2649c4c into develop Apr 17, 2024
6 checks passed
@titouanmathis titouanmathis mentioned this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants