-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add support for post request in Frame component #194
Conversation
Export Size@studiometa/ui
Unchanged@studiometa/ui
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #194 +/- ##
===========================================
+ Coverage 28.04% 28.14% +0.10%
===========================================
Files 54 49 -5
Lines 1362 1254 -108
Branches 253 243 -10
===========================================
- Hits 382 353 -29
+ Misses 980 832 -148
- Partials 0 69 +69
Flags with carried forward coverage won't be shown. Click here to find out more. β View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
Shall i add something more to this PR ? Try to add a bit of explanation on how the component work, does it seems right ? |
a31f8e3
to
4c712c8
Compare
π Linked issue
β Type of change
π Description
Add support for POST request for the Frame component.
Based on current implementation on a project.
Not really convinced this is the my robust way of doing it. i'm also wondering if this is going to work onWindowPopstate.
Requesting review to have feedback before processing to documentation, tests, etc
π Checklist