Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add CircularMarquee atom component #171

Merged
merged 9 commits into from
Feb 29, 2024
Merged

Feat: Add CircularMarquee atom component #171

merged 9 commits into from
Feb 29, 2024

Conversation

perruche
Copy link
Contributor

@perruche perruche commented Feb 27, 2024 •
edited
Loading

🔗 Linked issue

#66

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.
  • I have updated the changelog.

@perruche perruche added the enhancement New feature or request label Feb 27, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 27, 2024 •
edited
Loading

Export Size

Unchanged

@studiometa/ui

Name Size Diff
AbstractPrefetch 411 B -
AbstractScrollAnimation 461 B -
AbstractSliderChild 2.42 kB -
Accordion 1.06 kB -
AccordionItem 1.02 kB -
Action 508 B -
ALL 10.98 kB -
AnchorScrollTo 243 B -
animationScrollWithEase 272 B -
ATOMS 3.68 kB -
CircularMarquee 339 B -
Cursor 665 B -
Draggable 327 B -
Figure 694 B -
FigureTwicpics 1.06 kB -
Frame 1.62 kB -
FrameAnchor 201 B -
FrameForm 198 B -
FrameTarget 777 B -
LargeText 492 B -
LazyInclude 418 B -
loadImage 694 B -
Menu 1.38 kB -
MenuBtn 230 B -
MenuList 943 B -
Modal 908 B -
ModalWithTransition 1.02 kB -
MOLECULES 6.83 kB -
ORGANISMS 1.68 kB -
Panel 1.26 kB -
PrefetchWhenOver 468 B -
PrefetchWhenVisible 480 B -
PRIMITIVES 632 B -
ScrollAnimation 513 B -
ScrollAnimationChild 650 B -
ScrollAnimationChildWithEase 851 B -
ScrollAnimationParent 712 B -
ScrollAnimationWithEase 711 B -
ScrollReveal 622 B -
Sentinel 217 B -
Slider 2.21 kB -
SliderBtn 2.58 kB -
SliderCount 2.45 kB -
SliderDots 2.67 kB -
SliderDrag 353 B -
SliderItem 705 B -
SliderProgress 2.49 kB -
Sticky 859 B -
TableOfContent 647 B -
TableOfContentAnchor 460 B -
Tabs 625 B -
Transition 387 B -

@perruche perruche marked this pull request as draft February 27, 2024 15:08
titouanmathis
titouanmathis requested changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@titouanmathis titouanmathis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the effect! 👍

Some minor tweaks before merging.

packages/docs/components/atoms/CircularMarquee/stories/app.twig Outdated Show resolved Hide resolved
packages/docs/components/atoms/CircularMarquee/twig-api.md Outdated Show resolved Hide resolved
packages/docs/components/atoms/CircularMarquee/twig-api.md Outdated Show resolved Hide resolved
packages/ui/atoms/CircularMarquee/CircularMarquee.ts Outdated Show resolved Hide resolved
@perruche perruche marked this pull request as ready for review February 29, 2024 08:28
@titouanmathis titouanmathis merged commit 6c59bcd into develop Feb 29, 2024
6 checks passed
@titouanmathis titouanmathis deleted the feature/circularmarquee branch March 7, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titouanmathis titouanmathis titouanmathis approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggestion: Add a CircularMarquee component
2 participants
@perruche @titouanmathis