Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/accessibility iconimginline #143

Merged
merged 3 commits into from
Sep 14, 2023

Conversation

perruche
Copy link
Contributor

@perruche perruche commented Sep 12, 2023

Edit IconImgInline component

Goal: avoid accessibility issues while using the component

  • Edit IconImgInline to always have the alt attribute (empty string attributes are removed by the merge_html_attributes function)
  • Edit IconImgInline to have aria-hidden=true, since this component is meant to be used for non informative content

Thanks @Guillaume-meta for noticing the issue

@perruche perruche self-assigned this Sep 12, 2023
@perruche perruche added the enhancement New feature or request label Sep 12, 2023
@github-actions
Copy link

Export Size

Unchanged

@studiometa/ui

Name Size Diff
AbstractPrefetch 411 B -
AbstractScrollAnimation 461 B -
AbstractSliderChild 2.42 kB -
Accordion 1.06 kB -
AccordionItem 1.02 kB -
ALL 10.63 kB -
AnchorScrollTo 243 B -
animationScrollWithEase 272 B -
ATOMS 3.3 kB -
Cursor 665 B -
Draggable 327 B -
Figure 694 B -
FigureTwicpics 1.06 kB -
Frame 1.62 kB -
FrameAnchor 201 B -
FrameForm 198 B -
FrameTarget 777 B -
LargeText 492 B -
LazyInclude 418 B -
loadImage 694 B -
Menu 1.38 kB -
MenuBtn 230 B -
MenuList 943 B -
Modal 908 B -
ModalWithTransition 1.02 kB -
MOLECULES 6.83 kB -
ORGANISMS 1.68 kB -
Panel 1.26 kB -
PrefetchWhenOver 468 B -
PrefetchWhenVisible 480 B -
PRIMITIVES 632 B -
ScrollAnimation 513 B -
ScrollAnimationChild 650 B -
ScrollAnimationChildWithEase 851 B -
ScrollAnimationParent 712 B -
ScrollAnimationWithEase 711 B -
ScrollReveal 622 B -
Sentinel 217 B -
Slider 2.21 kB -
SliderBtn 2.58 kB -
SliderCount 2.45 kB -
SliderDots 2.67 kB -
SliderDrag 353 B -
SliderItem 705 B -
SliderProgress 2.49 kB -
Sticky 859 B -
TableOfContent 647 B -
TableOfContentAnchor 460 B -
Tabs 625 B -
Transition 387 B -

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fc2e8d4) 26.34% compared to head (93e7c41) 26.34%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #143   +/-   ##
========================================
  Coverage    26.34%   26.34%           
========================================
  Files           46       46           
  Lines         1154     1154           
  Branches       216      216           
========================================
  Hits           304      304           
  Misses         784      784           
  Partials        66       66           
Flag Coverage Δ
unittests 26.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@titouanmathis titouanmathis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, could you update the changelog as well?

Copy link
Contributor

@titouanmathis titouanmathis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@titouanmathis titouanmathis merged commit 5b49e47 into develop Sep 14, 2023
9 checks passed
@titouanmathis titouanmathis deleted the feature/accessibility-iconimginline branch September 14, 2023 12:03
@titouanmathis titouanmathis mentioned this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants