-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/accessibility iconimginline #143
Conversation
Export SizeUnchanged@studiometa/ui
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #143 +/- ##
========================================
Coverage 26.34% 26.34%
========================================
Files 46 46
Lines 1154 1154
Branches 216 216
========================================
Hits 304 304
Misses 784 784
Partials 66 66
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix, could you update the changelog as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Edit IconImgInline component
Goal: avoid accessibility issues while using the component
merge_html_attributes
function)Thanks @Guillaume-meta for noticing the issue