[Feature] Add a readmore component
#106
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Liax
requested review from
antoine4livre,
Guillaume-meta,
perruche and
titouanmathis
Export SizeUnchanged@studiometa/ui
|
Codecov Report
@@ Coverage Diff @@
## develop #106 +/- ##
===========================================
- Coverage 26.64% 26.16% -0.49%
===========================================
Files 46 47 +1
Lines 1141 1162 +21
Branches 211 216 +5
===========================================
Hits 304 304
- Misses 771 792 +21
Partials 66 66
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
titouanmathis
requested changes
Jan 10, 2023
titouanmathis
changed the title
readmore component
advanced usage. Implement dedicated methods for the show anb hide
|
Nice ! |
notjb
reviewed
Apr 23, 2024
| */ | ||
| hide() { | ||
| this.$refs.hiddenContent.classList.add('hidden'); | ||
| this.$refs.btn.innerHTML = this.$options.btnLabelMore; |
There was a problem hiding this comment.
suggestion: innerHTML might be unsafe. Consider using textContent instead 😇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
First draft of a
readmorecomponent.To do