[Feature] Add a placeholder_color param to Figure
#104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoine4livre
changed the title
placeholder_color param to Figure #100placeholder_color param to Figure
Export SizeUnchanged@studiometa/ui
|
Codecov Report
@@ Coverage Diff @@
## develop #104 +/- ##
========================================
Coverage 26.64% 26.64%
========================================
Files 46 46
Lines 1141 1141
Branches 211 211
========================================
Hits 304 304
Misses 771 771
Partials 66 66
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@titouanmathis Ready for an express review 🙂 |
|
@antoine4livre could you update the doc as well? Thanks for the PR! |
titouanmathis
requested changes
Dec 27, 2022
|
@titouanmathis @perruche I have updated the related documentation. |
titouanmathis
requested changes
Jan 4, 2023
Co-authored-by: Titouan Mathis <titouan@studiometa.fr>
Co-authored-by: Titouan Mathis <titouan@studiometa.fr>
titouanmathis
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
placeholder_colorparam to Figure (51f625d, #100)