Add options to the StructurizrDslParser #256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing behaviors. The only option is to force unique constant declaration, in order to prevent constants override inside a workspace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #253
After digging a bit more into the parser, it seems that adding a property to the DSL to be able to force constant declaration uniqueness is not trivial. Indeed, since the parsing is purely linear and checks rules "just in time", I did not see a simple way to prevent overrides before actually parsing the property that would forbid them.
Hence, I made this PR as a suggestion to at least allow people who use the StructurizrDslParser API directly in code to parametrize this behavior via options passed to the parser on invocation.
The only option is to force unique constant declaration, in order to prevent constants override inside a workspace.
Even if there is only one option, I feel like creating a dedicated object that contains everything will be more extensible in the probable case where one would suggest more parametrization of the parser behavior.