Skip to content

Commit

Permalink
Wording tweak.
Browse files Browse the repository at this point in the history
  • Loading branch information
Simon Brown committed Feb 18, 2024
1 parent 6db3a01 commit 371d570
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public GeneratedKeyInspection(Inspector inspector) {
@Override
protected Violation inspect(View view) {
if (view.isGeneratedKey()) {
return violation("The view with key \"" + view.getKey() + "\" has an automatically generated view key, which is not guaranteed to be stable over time.");
return violation("The view with key \"" + view.getKey() + "\" has an automatically generated view key and this is not guaranteed to be stable over time.");
}

return noViolation();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public ManualLayoutInspection(Inspector inspector) {
@Override
protected Violation inspect(ModelView view) {
if (view.isGeneratedKey() && view.getAutomaticLayout() == null) {
return violation("The view with key \"" + view.getKey() + "\" has an automatically generated view key, which may cause manual layout information to be lost in the future.");
return violation("The view with key \"" + view.getKey() + "\" has an automatically generated view key and this may cause manual layout information to be lost in the future.");
}

return noViolation();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public void run_GeneratedKey() {
Violation violation = new GeneratedKeyInspection(new DefaultInspector(workspace)).run(view);
Assertions.assertEquals(Severity.ERROR, violation.getSeverity());
assertEquals("views.view.key", violation.getType());
assertEquals("The view with key \"SystemLandscape-001\" has an automatically generated view key, which is not guaranteed to be stable over time.", violation.getMessage());
assertEquals("The view with key \"SystemLandscape-001\" has an automatically generated view key and this is not guaranteed to be stable over time.", violation.getMessage());
}

@Test
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public void run_GeneratedKeyAndManualLayout() {
Violation violation = new ManualLayoutInspection(new DefaultInspector(workspace)).run(view);
Assertions.assertEquals(Severity.ERROR, violation.getSeverity());
assertEquals("views.view.layout", violation.getType());
assertEquals("The view with key \"SystemLandscape-001\" has an automatically generated view key, which may cause manual layout information to be lost in the future.", violation.getMessage());
assertEquals("The view with key \"SystemLandscape-001\" has an automatically generated view key and this may cause manual layout information to be lost in the future.", violation.getMessage());
}

@Test
Expand Down

0 comments on commit 371d570

Please sign in to comment.