Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

element_path method added #263

Closed
wants to merge 3 commits into from
Closed

element_path method added #263

wants to merge 3 commits into from

Conversation

alexey-voronenko
Copy link
Contributor

@coveralls
Copy link

coveralls commented Dec 14, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling d79d3b8 on path-method into 17fda42 on master.

romikoops
romikoops reviewed Dec 15, 2017
View reviewed changes
lib/howitzer/log.rb
@@ -107,7 +107,7 @@ def default_formatter
params = if Howitzer.hide_datetime_from_log
{ pattern: '[%l] %m' }
else
{ pattern: '%d [%l] :: %m', date_pattern: '%Y/%m/%d %H:%M:%S' }
{ pattern: '%<day>d [%l] :: %m', date_pattern: '%Y/%m/%<day>d %H:%M:%S' }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???

Copy link
Contributor Author

@alexey-voronenko alexey-voronenko Dec 15, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shows errors like this:

lib/howitzer/log.rb:110:30: C: Style/FormatStringToken: Prefer annotated tokens (like %<foo>s) over unannotated tokens (like %s).
                 { pattern: '%d [%l] :: %m', date_pattern: '%Y/%m/%d %H:%M:%S' }
                             ^^
lib/howitzer/log.rb:110:67: C: Style/FormatStringToken: Prefer annotated tokens (like %<foo>s) over unannotated tokens (like %s).
                 { pattern: '%d [%l] :: %m', date_pattern: '%Y/%m/%d %H:%M:%S' }
                                                                  ^^

romikoops
romikoops requested changes Dec 15, 2017
View reviewed changes
Copy link
Contributor

@romikoops romikoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Rubocop issue is there

@romikoops
Copy link
Contributor

This PR is not actual anymore due to issue #267

@romikoops romikoops closed this Jan 16, 2018
@romikoops romikoops deleted the path-method branch January 16, 2018 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romikoops romikoops romikoops requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexey-voronenko @coveralls @romikoops