custom_method decorator for defining static methods for custom API requests
#547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ob-stripe
force-pushed
the
ob-custom-method
branch
2 times, most recently
from
5c91e7f
to
2eb4116
Compare
ob-stripe
force-pushed
the
ob-custom-method
branch
from
2eb4116
to
5402272
Compare
remi-stripe
force-pushed
the
ob-delete-class-method
branch
from
bd2d74d
to
d085b71
Compare
remi-stripe
force-pushed
the
ob-custom-method
branch
from
5402272
to
4d4da70
Compare
|
@ob-stripe I added all custom methods and tests and rebased on the latest branch for deletion |
remi-stripe
force-pushed
the
ob-custom-method
branch
3 times, most recently
from
d8c301c
to
91f7806
Compare
ob-stripe
changed the title
custom_method decorator for defining static methods for custom API requestscustom_method decorator for defining static methods for custom API requests
ob-stripe
force-pushed
the
ob-custom-method
branch
from
91f7806
to
ef13b48
Compare
|
Released as 2.24.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe @remi-stripe
cc @stripe/api-libraries
This is similar to stripe/stripe-ruby#754. This PR defines a new
custom_methoddecorator that can be applied to resource classes to automatically define class methods for custom (non-CRUDL) API requests.The decorator checks if a method with the target name already exists, and if so it uses the new decorator
util.class_method_variantfrom #543 to avoid overwriting the existing method (that we assume to be an instance method).