Remove more deprecated methods #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakrym-stripe
approved these changes
Jan 23, 2024
|
Looks like it's not safe to remove |
anniel-stripe
added a commit
that referenced
this pull request
Jan 25, 2024
* Add StripeClient (#1200) * Generated files * Non-generated files * Tests * Inline one-off methods * _ prefix for private APIRequestor methods and attributes, remove extra _Proxy * Handle None options and tests fixes * Don't accept api_mode in methods that don't use it * Allow setting api_key, stripe_version, and stripe_account on StripeObject (#1201) * Allow setting api_key, stripe_version, and stripe_account on StripeObject * refactor * fmt * Don't mutate APIRequestor * Update README with StripeClient examples (#1202) * Update README with StripeClient examples * from stripe import StripeClient * fix test * fix test * Move _default_proxy to APIRequestor * Don't copy twice, rtype params with Unpack[RequestOptions] * More feedback * Test service exports * Deprecate `StripeObject.request` (#1203) * Remove StripeObject.request * Change to deprecated * Remove more deprecated methods (#1204) * Remove some deprecated methods * Add back ListObject and SearchResultObect request sending methods * Un-deprecate ListObject methods (#1205) * Un-deprecate ListObject methods * lint * Remove APIRequestor from public API (#1207) * Remove APIRequestor from public API * fmt * lint * Remove request option positional params from more methods (#1208)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did an audit of methods / classes with
@_util.deprecateddecorators. I removed ones that were for internal stripe-python use only (likeListObject.empty_list()), as well as interfaces that will already be broken since we made request options keyword-only in #1200.Changelog
APIRequestor.format_app_info(). This method was intended for internal stripe-python use only.StripeError.construct_error_object(). This method was intended for internal stripe-python use only.ListObject.empty_list(). This method was intended for internal stripe-python use only.SearchResultObject.empty_search_result(). This method was intended for internal stripe-python use only.StripeObject.ReprJSONEncoder. This class was intended for internal stripe-python use only.StripeObject.api_base. This property was defunct and returnedNone.