APIRequestor: don't mutate incoming multipart headers #1091
+28
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out from #1088 since it's a behavior change.
Also fixes the
filetests. Unfortunately the special multipart form behavior is implemented in api_requestor, but our mocks mock at the api_requestor level so in order to actually make assertions about multipart you have to mock at the http_client level.These tests were accidentally working because of the unintended mutation. Stopping the mutation broke them, but required the tests to change.
FileUpload is an alias for File, so I deleted
file_upload_test.pyas it's basically completely redundant.