Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated test_helper decorator #1013

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Remove deprecated test_helper decorator #1013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f2128c
Remove deprecated test_helper decorator
richardm-stripe Aug 16, 2023
4037b82
FiX
richardm-stripe Aug 16, 2023
635a262
Delete here too
richardm-stripe Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion stripe/api_resources/abstract/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
from stripe.api_resources.abstract.custom_method import custom_method

from stripe.api_resources.abstract.test_helpers import (
test_helpers,
APIResourceTestHelpers,
)

Expand Down
25 changes: 0 additions & 25 deletions stripe/api_resources/abstract/test_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

from stripe import error, util
from urllib.parse import quote_plus
from stripe.api_resources.abstract import APIResource


class APIResourceTestHelpers:
Expand Down Expand Up @@ -54,27 +53,3 @@ def instance_url(self):
base = self.class_url()
extn = quote_plus(id)
return "%s/%s" % (base, extn)


# TODO (next major)
def test_helpers(cls):
"""
The test_helpers decorator is deprecated and will be removed in a future version
of the library.
"""

def test_helpers_getter(self):
return self.TestHelpers(self)

if not issubclass(cls, APIResource):
raise ValueError(
"Could not apply @test_helpers decorator to %r."
" The class should a subclass of APIResource." % cls
)

cls.TestHelpers._resource_cls = cls
cls.TestHelpers._static_request = cls._static_request
cls.TestHelpers._static_request_stream = cls._static_request_stream

cls.test_helpers = property(test_helpers_getter)
return cls