Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Port native Audio providers to C# #2454

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Jklawreszuk
Copy link
Collaborator

PR Details

The goal of this PR is to make the Stride.Audio module fully working in C#, without worring about C++ build tools.

Todo

  • Port OpenAL to Silk.NET.OpenAL - complete and tested on SimpleAudio sample
  • Port Celt/Opus to .NET
  • Port XAudio to Silk.NET.XAudio - almost complete, but not tested yet
  • Port OpenSL ES to .NET - Silk.NET does not provide an OpenSLES wrapper, and Android considers it obsolete.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out. (Only OpenAL)

@Jklawreszuk Jklawreszuk marked this pull request as draft September 17, 2024 21:34
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the whole file got "touched" in the latest commit (maybe the encoding change or the EOL character). Try to keep the encoding on all file to be UTF-8 and EOL to be LF when pushing (but can be CRLF when checking out on Windows). Please check whether the git config option on Windows and Linux are consistent.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With that said, sometimes git does the strangest diff and it's out of our control (could be the case here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants