feat: Allow Reset Grid Properties for Layout in UI Editor (#1619) #2400
Conversation
+ added check to see if possible to reset otherwise disable
|
Thanks a bunch for the PR, this one doesn't look as straightforward so I'll pass it to @Kryptos-FR, hopefully he has time to get back to us |
|
I'll look into it. |
There was a problem hiding this comment.
Initial review of the code with some small remarks. I will need to do a second in-depth review when I have more time.
There might be a better place indeed to put the delegate (maybe implemented as a command). If it's a blocking issue, I'm ok to merge it (once my remarks are resolved) and do the refactoring later (in which case, please create a new issue for tracking it).
| @@ -13,6 +13,9 @@ | |||
| using Stride.Core.Quantum; | |||
| using Stride.Assets.Presentation.ViewModel; | |||
| using Stride.UI; | |||
| using System; | |||
There was a problem hiding this comment.
Nit: using should be sorted with System.* first
| var virtualNode = node.Factory.CreateVirtualNodePresenter(propertyNodeParent, property.Name, propertyType, order, | ||
| () => Getter(propertyContainerNode, propertyIndex), | ||
| o => Setter(undoRedoService, propertyContainerNode, propertyIndex, o)); | ||
| () => Getter(propertyContainerNode, propertyIndex), |
There was a problem hiding this comment.
Nit: formatting, the previous spacing was correct.
|
|
||
| return virtualNode; | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Some virutal nodes dont have a specific AssociatedNode that is applicable. |
| if (customOverride != null) | ||
| customOverride(this); |
There was a problem hiding this comment.
Prefer to use the ?.Invoke() pattern, as it's slightly faster.
customOverride?.Invoke(this);
PR Details
Allowing UI grid properties to be reset to base value in UI editor. 'Reset to base value' button by right clicking on properties doesn't allow to be reset.
Related Issue
Issue: #1619
Types of changes
Just a note: May need a recommendation on where the custom delegate function goes, for now I kept them in UIAssetNodeUpdater file, it may need to be moved elsewhere. I can remove those TODO comments as needed. Thank you!
Checklist