Add source command for pulsarctl #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
sijie
requested changes
Sep 10, 2019
| @@ -8,7 +8,8 @@ import ( | |||
| "github.com/streamnative/pulsarctl/pkg/ctl/cluster" | |||
| "github.com/streamnative/pulsarctl/pkg/ctl/completion" | |||
| "github.com/streamnative/pulsarctl/pkg/ctl/functions" | |||
| "github.com/streamnative/pulsarctl/pkg/ctl/tenant" | |||
| "github.com/streamnative/pulsarctl/pkg/ctl/sources" | |||
pkg/ctl/sources/create.go
Outdated
| func createSourcesCmd(vc *cmdutils.VerbCmd) { | ||
| desc := pulsar.LongDescription{} | ||
| desc.CommandUsedFor = "Submit a Pulsar IO source connector to run in a Pulsar cluster." | ||
| desc.CommandPermission = "This command requires super-user permissions." |
pkg/ctl/sources/create.go
Outdated
| "\t--name <the name of Pulsar Source> \n" + | ||
| "\t--destination-topic-name kafka-topic \n" + | ||
| "\t--classname org.apache.pulsar.io.kafka.KafkaBytesSource \n" + | ||
| "\t--archive file:/http: + /examples/api-examples.nar", |
There was a problem hiding this comment.
this example is confusing. is it file:// or http://?
pkg/ctl/sources/delete.go
Outdated
| func deleteSourcesCmd(vc *cmdutils.VerbCmd) { | ||
| desc := pulsar.LongDescription{} | ||
| desc.CommandUsedFor = "This command is used for delete a Pulsar IO source connector." | ||
| desc.CommandPermission = "This command requires super-user permissions." |
There was a problem hiding this comment.
please check if the permission is correct?
pkg/ctl/sources/delete.go
Outdated
|
|
||
| func deleteSourcesCmd(vc *cmdutils.VerbCmd) { | ||
| desc := pulsar.LongDescription{} | ||
| desc.CommandUsedFor = "This command is used for delete a Pulsar IO source connector." |
There was a problem hiding this comment.
Suggested change
| desc.CommandUsedFor = "This command is used for delete a Pulsar IO source connector." | |
| desc.CommandUsedFor = "This command is used for deleting a Pulsar IO source connector." |
pkg/ctl/sources/get.go
Outdated
| func getSourcesCmd(vc *cmdutils.VerbCmd) { | ||
| desc := pulsar.LongDescription{} | ||
| desc.CommandUsedFor = "Gets the information about a Pulsar IO source connector" | ||
| desc.CommandPermission = "This command requires super-user permissions." |
pkg/ctl/sources/list.go
Outdated
| func listSourcesCmd(vc *cmdutils.VerbCmd) { | ||
| desc := pulsar.LongDescription{} | ||
| desc.CommandUsedFor = "List all running Pulsar IO source connectors" | ||
| desc.CommandPermission = "This command requires super-user permissions." |
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
|
@sijie done PTAL again, thanks. |
sijie
approved these changes
Sep 10, 2019
|
@wolfstudy please rebase |
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
tisonkun
pushed a commit
to tisonkun/pulsar-client-go
that referenced
this pull request
Aug 15, 2023
Signed-off-by: xiaolong.ran ranxiaolong716@gmail.com Add source command for pulsarctl - createSourcesCmd - updateSourcesCmd - deleteSourcesCmd - getSourcesCmd - listSourcesCmd - stopSourcesCmd - startSourcesCmd - restartSourcesCmd - statusSourcesCmd
tisonkun
pushed a commit
to apache/pulsar-client-go
that referenced
this pull request
Aug 16, 2023
Signed-off-by: xiaolong.ran ranxiaolong716@gmail.com Add source command for pulsarctl - createSourcesCmd - updateSourcesCmd - deleteSourcesCmd - getSourcesCmd - listSourcesCmd - stopSourcesCmd - startSourcesCmd - restartSourcesCmd - statusSourcesCmd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xiaolong.ran ranxiaolong716@gmail.com
Add source command for
pulsarctl