Add update cmd for Pulsar Functions #33

wolfstudy · 2019-09-04T09:29:50Z

Add update cmd for Pulsar Functions, output as follows:

USED FOR:
    Update a Pulsar Function that has been deployed to a Pulsar cluster.

REQUIRED PERMISSION:
    This command requires super-user permissions.

EXAMPLES:
    #Update output topic of Pulsar Function
    pulsarctl functions update
	--tenant public
	--namespace default
	--name update-function
	--output test-output-topic

    #Update function config yaml file of Pulsar Function
    pulsarctl functions update
	--function-config-file <the path of function config yaml file>
	--jar <the path of user code jar>

    #Update log topic of Pulsar Function
    pulsarctl functions update
	--log-topic persistent://public/default/test-log-topic
	# Other function parameters

    #Update dead letter topic of Pulsar Function
    pulsarctl functions update
	--dead-letter-topic persistent://public/default/test-dead-letter-topic
	--max-message-retries 10
	# Other function parameters

    #Update user config of Pulsar Function
    pulsarctl functions update
	--user-config "{"publishTopic":"publishTopic", "key":"pulsar"}"
	# Other function parameters

    #Update custom schema of inputs topic for Pulsar Function
    pulsarctl functions update
	--custom-schema-inputs "{"topic-1":"schema.STRING", "topic-2":"schema.JSON"}"
	# Other function parameters

    #Update schema type of output topic for Pulsar Function
    pulsarctl functions update
	--schema-type schema.STRING
	# Other function parameters

    #Update parallelism of Pulsar Function
    pulsarctl functions update
	--parallelism 1
	# Other function parameters

    #Update resource of Pulsar Function
    pulsarctl functions update
	--ram 5656565656
	--disk 8080808080808080
	--cpu 5.0
	# Other function parameters

    #Update window functions config of Pulsar Function
    pulsarctl functions update
	--window-length-count 10
	--window-length-duration-ms 1000
	--sliding-interval-count 3
	--sliding-interval-duration-ms 1000
	# Other function parameters

OUTPUT:
    #normal output
    Updated successfully

    #Update contains no change
    [✖]  code: 400 reason: Update contains no change

    #The name of Pulsar Functions doesn't exist, please check the --name args
    [✖]  code: 404 reason: Function <your function name> doesn't exist

Usage: pulsarctl functions update [flags]

Aliases: update, update

Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>

wolfstudy · 2019-09-04T09:50:05Z

@sijie @zymap PTAL

pkg/ctl/functions/update.go

sijie · 2019-09-04T14:45:43Z

pkg/ctl/functions/update.go

+	}
+	examples = append(examples, update)
+
+	updateWithConf := pulsar.Example{


Update a Pulsar Function using a function config yaml file

pkg/ctl/functions/update.go

sijie · 2019-09-04T14:46:11Z

pkg/ctl/functions/update.go

+	examples = append(examples, updateWithLogTopic)
+
+	updateWithDeadLetterTopic := pulsar.Example{
+		Desc: "Update dead letter topic of Pulsar Function",


Change the dead letter topic of a Pulsar Function

sijie · 2019-09-04T14:46:50Z

pkg/ctl/functions/update.go

+	}
+	examples = append(examples, updateWithDeadLetterTopic)
+
+	updateWithUserConfig := pulsar.Example{


Update the user configs of a Pulsar Function

Please change Pulsar Function to a Pulsar Function in other places.

sijie · 2019-09-04T14:48:11Z

pkg/ctl/functions/update.go

+	examples = append(examples, updateWithCustomSchemasInputs)
+
+	updateWithSchema := pulsar.Example{
+		Desc: "Update schema type of output topic for Pulsar Function",


I think this is for input topic, not for output topic, no?

If it is for input topic, change it to Change the schema type of the input topic for a Pulsar Function.

sijie · 2019-09-04T14:48:29Z

pkg/ctl/functions/update.go

+	}
+	examples = append(examples, updateWithSchema)
+
+	updateWithParallelism := pulsar.Example{


Change the parallelism of a Pulsar Function

sijie · 2019-09-04T14:48:43Z

pkg/ctl/functions/update.go

+	examples = append(examples, updateWithParallelism)
+
+	updateWithResource := pulsar.Example{
+		Desc: "Update resource of Pulsar Function",


Change the resource usage for a Pulsar Function

sijie · 2019-09-04T14:49:17Z

pkg/ctl/functions/update.go

+	examples = append(examples, updateWithResource)
+
+	updateWithWindowFunctions := pulsar.Example{
+		Desc: "Update window functions config of Pulsar Function",


Update the window configurations for a Pulsar Function

sijie · 2019-09-04T14:50:02Z

pkg/ctl/functions/update.go

+	var out []pulsar.Output
+	successOut := pulsar.Output{
+		Desc: "normal output",
+		Out:  "Updated successfully",


don't we have the function name in the output?

Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>

wolfstudy · 2019-09-05T06:01:23Z

@sijie PTAL again

Add update cmd for Pulsar Functions, output as follows: ``` USED FOR: Update a Pulsar Function that has been deployed to a Pulsar cluster. REQUIRED PERMISSION: This command requires super-user permissions. EXAMPLES: #Update output topic of Pulsar Function pulsarctl functions update --tenant public --namespace default --name update-function --output test-output-topic #Update function config yaml file of Pulsar Function pulsarctl functions update --function-config-file <the path of function config yaml file> --jar <the path of user code jar> #Update log topic of Pulsar Function pulsarctl functions update --log-topic persistent://public/default/test-log-topic # Other function parameters #Update dead letter topic of Pulsar Function pulsarctl functions update --dead-letter-topic persistent://public/default/test-dead-letter-topic --max-message-retries 10 # Other function parameters #Update user config of Pulsar Function pulsarctl functions update --user-config "{"publishTopic":"publishTopic", "key":"pulsar"}" # Other function parameters #Update custom schema of inputs topic for Pulsar Function pulsarctl functions update --custom-schema-inputs "{"topic-1":"schema.STRING", "topic-2":"schema.JSON"}" # Other function parameters #Update schema type of output topic for Pulsar Function pulsarctl functions update --schema-type schema.STRING # Other function parameters #Update parallelism of Pulsar Function pulsarctl functions update --parallelism 1 # Other function parameters #Update resource of Pulsar Function pulsarctl functions update --ram 5656565656 --disk 8080808080808080 --cpu 5.0 # Other function parameters #Update window functions config of Pulsar Function pulsarctl functions update --window-length-count 10 --window-length-duration-ms 1000 --sliding-interval-count 3 --sliding-interval-duration-ms 1000 # Other function parameters OUTPUT: #normal output Updated successfully #Update contains no change [✖] code: 400 reason: Update contains no change #The name of Pulsar Functions doesn't exist, please check the --name args [✖] code: 404 reason: Function <your function name> doesn't exist Usage: pulsarctl functions update [flags] Aliases: update, update ```

wolfstudy added 10 commits September 3, 2019 14:09

Add delete cmd for Pulsar Functions

9c3e7aa

Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>

fix comments

7cdab3f

Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>

Merge branch 'master' into xiaolong/delete-pulsar-functions

3b58aa9

fix comments

a568e78

Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>

Add start cmd for Pulsar Functions

c14b080

Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>

Add restart cmd for Pulsar Functions

3497ec8

Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>

Add list cmd for Pulsar Functions

27e2693

Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>

Add get cmd for Pulsar functions

ad15c9c

Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>

Add update cmd for Pulsar Functions

d820359

Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>

merge master code

0ef2ac6

Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>

wolfstudy requested review from sijie and zymap September 4, 2019 09:29

wolfstudy self-assigned this Sep 4, 2019

sijie requested changes Sep 4, 2019

View reviewed changes

fix comments

8353e81

Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>

sijie approved these changes Sep 5, 2019

View reviewed changes

sijie added area/pulsar/functions type/task Indicates a chore or a small item of work labels Sep 5, 2019

sijie added this to the 0.0.1 milestone Sep 5, 2019

sijie merged commit 18e5897 into master Sep 5, 2019

sijie deleted the xiaolong/update-pulsar-functions branch September 5, 2019 06:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add update cmd for Pulsar Functions #33

Add update cmd for Pulsar Functions #33

wolfstudy commented Sep 4, 2019

wolfstudy commented Sep 4, 2019

sijie Sep 4, 2019

sijie Sep 4, 2019

sijie Sep 4, 2019

sijie Sep 4, 2019

sijie Sep 4, 2019

sijie Sep 4, 2019

sijie Sep 4, 2019

sijie Sep 4, 2019

wolfstudy commented Sep 5, 2019

Add update cmd for Pulsar Functions #33

Add update cmd for Pulsar Functions #33

Conversation

wolfstudy commented Sep 4, 2019

wolfstudy commented Sep 4, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wolfstudy commented Sep 5, 2019