Add command cluster `create-failure-domain` #21

zymap · 2019-08-30T07:05:13Z

Master issue: #2

 USED FOR:
    This command is used for creating a failure domain of the <cluster-name>.

REQUIRED PERMISSION:
    This command requires super-user permissions.

EXAMPLES:
    #creating the failure domain
    pulsarctl clusters create-failure-domain <cluster-name> <domain-name>

    #creating the failure domain with brokers
    pulsarctl clusters create-failure-domain --broker-list <cluster-A> --broker-list <cluster-B> <cluster-name> <domain-name>

OUTPUT:
    #normal output
    Create failure domain <domain-name> for cluster <cluster-name> succeed

    #the args need to be specified as <cluster-name> <domain-name>
    [✖]  need specified two names for cluster and failure domain

    #the specified cluster does not exist in the broker
    [✖]  code: 404 reason: Cluster does not exist

Usage: pulsarctl clusters create-failure-domain [flags]

Aliases: create-failure-domain, cfd

FailureDomainData flags:
  -b, --broker-list strings   Set the failure domain clusters

Common flags:
  -s, --admin-service-url string    The admin web service url that pulsarctl connects to. (default "http://localhost:8080")
      --auth-params string          Authentication parameters are used to configure the public and private key files required by tls
                                     For example: "tlsCertFile:val1,tlsKeyFile:val2"
  -C, --color string                toggle colorized logs (true,false,fabulous) (default "true")
  -h, --help                        help for this command
      --tls-allow-insecure          Allow TLS insecure connection
      --tls-trust-cert-pat string   Allow TLS trust cert file path
  -v, --verbose int                 set log level, use 0 to silence, 4 for debugging (default 3)

Use 'pulsarctl clusters create-failure-domain [command] --help' for more information about a command.

--- Master Issue: #2

sijie · 2019-09-03T04:01:45Z

The output doesn't seem to be correct to me.

    #normao output
    Create failure domain <domain-name> for cluster <cluster-name> succeed

    #output of doesn't specified a cluster name
    [✖]  only one argument is allowed to be used as a name

    #output of cluster doesn't exist
    [✖]  code: 404 reason: Cluster does not exist

zymap · 2019-09-03T04:05:21Z

@sijie Ah. It already fixes in the code. I forget fix the description of this pull request.

pkg/ctl/cluster/create_failure_domain.go

sijie · 2019-09-03T04:15:33Z

pkg/ctl/cluster/create_failure_domain.go

+	}
+	out = append(out, successOut)
+	out = append(out, argsError)
+	out = append(out, clusterNonExist)


clusterNonExist is for cluster commands. please make sure the error message is correct.

pkg/ctl/cluster/create_failure_domain.go

Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>

zymap · 2019-09-03T06:27:50Z

@sijie PTAL

sijie · 2019-09-03T07:00:19Z

pkg/ctl/cluster/create_failure_domain_test.go

+	"testing"
+)
+
+func TestCreateFailureDomainCmdSuccess(t *testing.T) {


please add test cases for failure cases.

sijie · 2019-09-03T07:01:18Z

pkg/ctl/cluster/create_failure_domain.go

+	desc.CommandPermission = "This command requires super-user permissions."
+
+	var examples []pulsar.Example
+	create := pulsar.Example{


does Pulsar allow creating a failure domain without a broker list?

I don't think that is a valid case.

yes. I will check the broker list in pulsarctl.

Using pulsar-admin

bin/pulsar-admin clusters create-failure-domain --domain-name hello standalone bin/pulsar-admin clusters list-failure-domains standalone { "hello" : { "brokers" : [ ] } }

### Motivation We can't get the error info when running a command. When testing a command, we need to verify the error output. ### Modification Make a handler to handle errors. Create a test handler in TestClusterCommand for test other commands.

--- Master Issue: #2

Master issue: streamnative/pulsarctl#2 ``` USED FOR: This command is used for creating a failure domain of the <cluster-name>. REQUIRED PERMISSION: This command requires super-user permissions. EXAMPLES: #creating the failure domain pulsarctl clusters create-failure-domain <cluster-name> <domain-name> #creating the failure domain with brokers pulsarctl clusters create-failure-domain --broker-list <cluster-A> --broker-list <cluster-B> <cluster-name> <domain-name> OUTPUT: #normal output Create failure domain <domain-name> for cluster <cluster-name> succeed #the args need to be specified as <cluster-name> <domain-name> [✖] need specified two names for cluster and failure domain #the specified cluster does not exist in the broker [✖] code: 404 reason: Cluster does not exist Usage: pulsarctl clusters create-failure-domain [flags] Aliases: create-failure-domain, cfd FailureDomainData flags: -b, --broker-list strings Set the failure domain clusters Common flags: -s, --admin-service-url string The admin web service url that pulsarctl connects to. (default "http://localhost:8080") --auth-params string Authentication parameters are used to configure the public and private key files required by tls For example: "tlsCertFile:val1,tlsKeyFile:val2" -C, --color string toggle colorized logs (true,false,fabulous) (default "true") -h, --help help for this command --tls-allow-insecure Allow TLS insecure connection --tls-trust-cert-pat string Allow TLS trust cert file path -v, --verbose int set log level, use 0 to silence, 4 for debugging (default 3) Use 'pulsarctl clusters create-failure-domain [command] --help' for more information about a command. ```

zymap self-assigned this Aug 30, 2019

zymap added the area/pulsar/clusters label Aug 30, 2019

zymap added this to the 0.0.1 milestone Aug 30, 2019

zymap changed the title ~~[WIP] Clusters create failure domain~~ [WIP] Add command cluster create-failure-domain Aug 30, 2019

zymap force-pushed the clusters_create_failure_domain branch 2 times, most recently from 9902b67 to d230065 Compare September 3, 2019 02:43

zymap requested a review from sijie September 3, 2019 02:46

zymap changed the title ~~[WIP] Add command cluster create-failure-domain~~ Add command cluster create-failure-domain Sep 3, 2019

zymap requested review from wolfstudy and removed request for sijie September 3, 2019 02:46

zymap removed their assignment Sep 3, 2019

zymap requested a review from sijie September 3, 2019 02:46

zymap self-assigned this Sep 3, 2019

zymap added 5 commits September 3, 2019 11:55

Add command cluster get-peer-clusters

b4fa7eb

--- Master Issue: #2

Add command cluster create-failure-domain

18e6420

Fix typo

9904852

Add an empty line

528e494

Fix build

919d4d0

zymap force-pushed the clusters_create_failure_domain branch from 386fda2 to 919d4d0 Compare September 3, 2019 03:56

sijie requested changes Sep 3, 2019

View reviewed changes

wolfstudy and others added 2 commits September 3, 2019 13:38

Add stop cmd for Pulsar Functions (#25)

b3721e6

Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>

Address comments

664934d

format code

1e6457b

sijie requested changes Sep 3, 2019

View reviewed changes

zymap added 3 commits September 3, 2019 16:50

Add handler to handle test error (#27)

064bb44

### Motivation We can't get the error info when running a command. When testing a command, we need to verify the error output. ### Modification Make a handler to handle errors. Create a test handler in TestClusterCommand for test other commands.

Add command cluster get-peer-clusters

ed3f709

--- Master Issue: #2

Add command cluster create-failure-domain

9b271e2

zymap added 7 commits September 3, 2019 17:42

Fix typo

6366905

Add an empty line

562ef27

Fix build

851cbf8

Address comments

3d4ccb6

format code

a0d049a

address comments

a38ce86

Fix conflicts

0327cdb

sijie approved these changes Sep 3, 2019

View reviewed changes

sijie merged commit 0d9d8c3 into master Sep 3, 2019

sijie deleted the clusters_create_failure_domain branch September 3, 2019 19:05

sijie mentioned this pull request Sep 4, 2019

pulsarctl MVP #2

Closed

29 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add command cluster `create-failure-domain` #21

Add command cluster `create-failure-domain` #21

zymap commented Aug 30, 2019 •

edited

Loading

sijie commented Sep 3, 2019

zymap commented Sep 3, 2019

sijie Sep 3, 2019

zymap commented Sep 3, 2019

sijie Sep 3, 2019

sijie Sep 3, 2019

zymap Sep 3, 2019

sijie Sep 3, 2019

Add command cluster create-failure-domain #21

Add command cluster create-failure-domain #21

Conversation

zymap commented Aug 30, 2019 • edited Loading

sijie commented Sep 3, 2019

zymap commented Sep 3, 2019

sijie Sep 3, 2019

Choose a reason for hiding this comment

zymap commented Sep 3, 2019

sijie Sep 3, 2019

Choose a reason for hiding this comment

sijie Sep 3, 2019

Choose a reason for hiding this comment

zymap Sep 3, 2019

Choose a reason for hiding this comment

sijie Sep 3, 2019

Choose a reason for hiding this comment

Add command cluster `create-failure-domain` #21

Add command cluster `create-failure-domain` #21

zymap commented Aug 30, 2019 •

edited

Loading