Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add create cmd of Pulsar Functions #15

Merged
merged 17 commits into from
Sep 3, 2019
Merged

Add create cmd of Pulsar Functions #15

merged 17 commits into from
Sep 3, 2019

Conversation

wolfstudy
Copy link
Contributor

Signed-off-by: xiaolong.ran ranxiaolong716@gmail.com

Add create cmd of Pulsar Functions

@wolfstudy
Add create cmd of Pulsar Functions
ed3ea6f 
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
@wolfstudy wolfstudy added area/pulsar/functions type/feature Indicates new functionality labels Aug 29, 2019
@wolfstudy wolfstudy self-assigned this Aug 29, 2019
@wolfstudy wolfstudy requested review from sijie and zymap and removed request for sijie and zymap August 29, 2019 03:26
@wolfstudy
fix some bugs
aa229e3 
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
@wolfstudy
merge master code
d3ac425 
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
@wolfstudy
add createStringFromField for functions
d7eacd2 
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
@wolfstudy
fix post method for functions
0909cc3 
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
@wolfstudy wolfstudy changed the title [WIP] Add create cmd of Pulsar Functions Add create cmd of Pulsar Functions Aug 31, 2019
@wolfstudy wolfstudy requested review from sijie and zymap August 31, 2019 10:12
@wolfstudy
Copy link
Contributor Author

@sijie @zymap

Please review this pull request main logic.

@wolfstudy
fix a little
87480cc 
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
sijie
sijie requested changes Sep 1, 2019
View reviewed changes
Copy link
Member

@sijie sijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add tests and improve the documentation.

please check how Yong did for cluster commands.

@wolfstudy
add unit test case for create functions
450c9a5 
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
sijie
sijie requested changes Sep 2, 2019
View reviewed changes
Copy link
Member

@sijie sijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we shouldn't add binary to source repo. test/functions/api-examples.jar . Can you think of improving it?

pkg/ctl/functions/create.go Outdated
)

functionData := &pulsar.FunctionData{}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add examples and output. See https://github.com/streamnative/pulsarctl/blob/master/pkg/ctl/cluster/update.go#L14

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, will fix it

@wolfstudy
add long descriptions for create functions
dfb789f 
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
@wolfstudy
add create function with url for project
4aca224 
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
@wolfstudy
Merge branch 'master' into xiaolong/functions-cmd-localrun
fbc3bd7
@wolfstudy
fix post method for ci
873097b 
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
@wolfstudy
remove example.jar file
9d35c6b 
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
@wolfstudy
Copy link
Contributor Author

Ideally we shouldn't add binary to source repo. test/functions/api-examples.jar . Can you think of improving it?

In create function, i create a dummy jar file, replace api-examples.jar

@wolfstudy
fix ci test
f1d68d8 
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
@wolfstudy
add long description for create function
8519fcb 
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
@wolfstudy
fix a little
441fb3b 
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
zymap
zymap reviewed Sep 2, 2019
View reviewed changes
pkg/ctl/functions/create.go Outdated Show resolved Hide resolved
zymap
zymap reviewed Sep 2, 2019
View reviewed changes
pkg/ctl/functions/create.go Outdated Show resolved Hide resolved
@wolfstudy
fix comments
39aaf83 
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
@wolfstudy
fix comments
59a59d5 
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
@wolfstudy
Copy link
Contributor Author

@sijie @zymap PTAL again

@sijie sijie added this to the 0.0.1 milestone Sep 3, 2019
@sijie sijie merged commit 035e17b into master Sep 3, 2019
@sijie sijie deleted the xiaolong/functions-cmd-localrun branch September 3, 2019 03:50
@sijie sijie mentioned this pull request Sep 4, 2019
Closed
29 tasks
tisonkun pushed a commit to tisonkun/pulsar-client-go that referenced this pull request Aug 15, 2023
@wolfstudy @tisonkun
Add create cmd of Pulsar Functions (streamnative/pulsarctl#15)
1e28e8f 
Add create cmd of Pulsar Functions
tisonkun pushed a commit to apache/pulsar-client-go that referenced this pull request Aug 16, 2023
@wolfstudy @tisonkun
Add create cmd of Pulsar Functions (streamnative/pulsarctl#15)
1f646f5 
Add create cmd of Pulsar Functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

@zymap zymap zymap approved these changes

Assignees

@wolfstudy wolfstudy

Labels
area/pulsar/functions type/feature Indicates new functionality
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@wolfstudy @sijie @zymap