This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
fix: Fix wrong model field #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuteng
approved these changes
Aug 12, 2023
BewareMyPower
approved these changes
Aug 12, 2023
There was a problem hiding this comment.
Could you explain more about it? It's very disappointing and confusing to see the ecosystem must keep the same field name with the Java client. It even makes the Java side more easily to make breaking changes. IIUC, if I changed any protected field of MessageIdImpl, a new breaking change would be introduced.
|
@BewareMyPower |
|
In the previous design, pulsar-admin-go choose to use |
BewareMyPower
approved these changes
Aug 13, 2023
|
@tuteng could you please cherry-pick it to previous branches by any chance? |
tisonkun
pushed a commit
to tisonkun/pulsar-client-go
that referenced
this pull request
Aug 15, 2023
Master Issue: streamnative/pulsar-admin-go#2 ##OUTPUT *last-message-id* ``` ➜ pulsarctl git:(topic-lastmessage) ./pulsarctl topic last-message-id -h USED FOR: This command is used for getting the last message id of a topic (partition). REQUIRED PERMISSION: This command requires tenant admin permissions. EXAMPLES: #Get the last message id of a topic <persistent-topic-name> pulsarctl topic last-message-id <persistent-topic-name> #Get the last message id of a partitioned topic <topic-name> pulsarctl topic last-message-id --partition-index <partition> <topic-name> OUTPUT: #normal output { "LedgerId": 0, "EntryId": 0, "PartitionedIndex": 0 } #the topic name is not specified [✖] only one argument is allowed to be used as a name #the topic <persistent-topic-name> does not exist in the cluster [✖] code: 404 reason: Topic not found #the topic <persistent-topic-name> does not a persistent topic [✖] code: 405 reason: GetLastMessageId on a non-persistent topic is not allowed #the topic name is not in the format of <tenant>/<namespace>/<topic> or <topic> [✖] Invalid short topic name '<topic-name>', it should be in the format of <tenant>/<namespace>/<topic> or <topic> #the topic name is not in the format of <domain>://<tenant>/<namespace>/<topic> [✖] Invalid complete topic name '<topic-name>', it should be in the format of <domain>://<tenant>/<namespace>/<topic> #the topic name is not in the format of <tenant>/<namespace>/<topic> [✖] Invalid topic name '<topic-name>', it should be in the format of<tenant>/<namespace>/<topic> #the namespace name is not in the format of <tenant>/<namespace> [✖] The complete name of namespace is invalid. complete name : <namespace-complete-name> #the tenant name and(or) namespace name is empty [✖] Invalid tenant or namespace. [<tenant>/<namespace>] #the tenant name contains unsupported special chars. the alphanumeric (a-zA-Z0-9) and the special chars (-=:.%) is allowed [✖] Tenant name include unsupported special chars. tenant : [<namespace>] #the namespace name contains unsupported special chars. the alphanumeric (a-zA-Z0-9) and the special chars (-=:.%) is allowed [✖] Namespace name include unsupported special chars. namespace : [<namespace>] Usage: pulsarctl topics last-message-id [flags] Aliases: last-message-id, lmi ```
tisonkun
pushed a commit
to tisonkun/pulsar-client-go
that referenced
this pull request
Aug 15, 2023
Fix wrong model field
tisonkun
pushed a commit
to tisonkun/pulsar-client-go
that referenced
this pull request
Aug 15, 2023
Fix wrong model field
tisonkun
pushed a commit
to apache/pulsar-client-go
that referenced
this pull request
Aug 16, 2023
Fix wrong model field
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The Apache pulsar request model is as follows:
Modifications
PartitionedIndextoPartitionIndexVerification