This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
chore: add pull request template #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Xu <xuhuan@live.cn>
ericsyh
approved these changes
Jul 14, 2023
tuteng
approved these changes
Jul 14, 2023
tisonkun
pushed a commit
to tisonkun/pulsar-client-go
that referenced
this pull request
Aug 15, 2023
Add update cmd for Pulsar Functions, output as follows:
```
USED FOR:
Update a Pulsar Function that has been deployed to a Pulsar cluster.
REQUIRED PERMISSION:
This command requires super-user permissions.
EXAMPLES:
#Update output topic of Pulsar Function
pulsarctl functions update
--tenant public
--namespace default
--name update-function
--output test-output-topic
#Update function config yaml file of Pulsar Function
pulsarctl functions update
--function-config-file <the path of function config yaml file>
--jar <the path of user code jar>
#Update log topic of Pulsar Function
pulsarctl functions update
--log-topic persistent://public/default/test-log-topic
# Other function parameters
#Update dead letter topic of Pulsar Function
pulsarctl functions update
--dead-letter-topic persistent://public/default/test-dead-letter-topic
--max-message-retries 10
# Other function parameters
#Update user config of Pulsar Function
pulsarctl functions update
--user-config "{"publishTopic":"publishTopic", "key":"pulsar"}"
# Other function parameters
#Update custom schema of inputs topic for Pulsar Function
pulsarctl functions update
--custom-schema-inputs "{"topic-1":"schema.STRING", "topic-2":"schema.JSON"}"
# Other function parameters
#Update schema type of output topic for Pulsar Function
pulsarctl functions update
--schema-type schema.STRING
# Other function parameters
#Update parallelism of Pulsar Function
pulsarctl functions update
--parallelism 1
# Other function parameters
#Update resource of Pulsar Function
pulsarctl functions update
--ram 5656565656
--disk 8080808080808080
--cpu 5.0
# Other function parameters
#Update window functions config of Pulsar Function
pulsarctl functions update
--window-length-count 10
--window-length-duration-ms 1000
--sliding-interval-count 3
--sliding-interval-duration-ms 1000
# Other function parameters
OUTPUT:
#normal output
Updated successfully
#Update contains no change
[✖] code: 400 reason: Update contains no change
#The name of Pulsar Functions doesn't exist, please check the --name args
[✖] code: 404 reason: Function <your function name> doesn't exist
Usage: pulsarctl functions update [flags]
Aliases: update, update
```
tisonkun
pushed a commit
to tisonkun/pulsar-client-go
that referenced
this pull request
Aug 15, 2023
Signed-off-by: Max Xu <xuhuan@live.cn>
tisonkun
pushed a commit
to tisonkun/pulsar-client-go
that referenced
this pull request
Aug 15, 2023
Signed-off-by: Max Xu <xuhuan@live.cn>
tisonkun
pushed a commit
to apache/pulsar-client-go
that referenced
this pull request
Aug 16, 2023
Signed-off-by: Max Xu <xuhuan@live.cn>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32
Motivation
To encourage contributors provide more context about a PR.
Modifications
add pull request template.
Verification
No code changes.