Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

ci: add conventional commits PR title checker #18

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Conversation

maxsxu
Copy link
Member

@maxsxu maxsxu commented Mar 23, 2023

Motivation

We respect the Conventional Commits Spec

We use squash and merge strategy, so we need ensure all PR titles matches the Conventional Commits spec

Signed-off-by: Max Xu <xuhuan@live.cn>
@maxsxu maxsxu requested a review from FushuWang March 23, 2023 13:21
@maxsxu maxsxu requested a review from a team as a code owner March 23, 2023 13:21
@maxsxu maxsxu self-assigned this Mar 23, 2023
@maxsxu maxsxu added this to the v0.1.0 milestone Mar 23, 2023
@maxsxu maxsxu merged commit 4862a89 into master Mar 23, 2023
@maxsxu maxsxu deleted the max/ci-pr-title branch March 23, 2023 14:37
tisonkun pushed a commit to tisonkun/pulsar-client-go that referenced this pull request Aug 15, 2023
…-go#18)

Master issue: streamnative/pulsar-admin-go#2 

output : 

```
USED FOR:
    This command is used for updating peer clusters.

REQUIRED PERMISSION:
    This command requires super-user permissions.

EXAMPLES:
    #updating the <cluster-name> peer clusters
    pulsarctl clusters update-peer-clusters -p cluster-a,cluster-b <cluster-name>

OUTPUT:
    #normal output
    <cluster-name> peer clusters updated

    #output of doesn't specified a cluster name
    [✖]  only one argument is allowed to be used as a name

    #output of cluster doesn't exist
    [✖]  code: 404 reason: Cluster does not exist

Usage: pulsarctl clusters update-peer-clusters [flags]

Aliases: update-peer-clusters, upc

Update peer clusters flags:
  -p, --peer-cluster stringArray   Cluster to be registered as a peer-cluster of this cluster

Common flags:
  -s, --admin-service-url string   The admin web service url that pulsarctl connects to. (default "http://localhost:8080")
  -C, --color string               toggle colorized logs (true,false,fabulous) (default "true")
  -h, --help                       help for this command
  -v, --verbose int                set log level, use 0 to silence, 4 for debugging (default 3)

Use 'pulsarctl clusters update-peer-clusters [command] --help' for more information about a command.
```
tisonkun pushed a commit to tisonkun/pulsar-client-go that referenced this pull request Aug 15, 2023
…min-go#18)

ci: add PR title checker

Signed-off-by: Max Xu <xuhuan@live.cn>
tisonkun pushed a commit to tisonkun/pulsar-client-go that referenced this pull request Aug 15, 2023
…min-go#18)

ci: add PR title checker

Signed-off-by: Max Xu <xuhuan@live.cn>
tisonkun pushed a commit to apache/pulsar-client-go that referenced this pull request Aug 16, 2023
…min-go#18)

ci: add PR title checker

Signed-off-by: Max Xu <xuhuan@live.cn>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants