ci: add new CI jobs and bring existing ones into compliance #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
# Conflicts: # chain/ethereum/ethererum_chain.go # chain/ethereum/foundry/forge.go # examples/ethereum/foundry_test.go # examples/thorchain/chainspec_thorchain.go # examples/thorchain/helper.go # examples/thorchain/setup.go
Update the goreleaser CI action to be compliant with our OSS template
Updates the goreleaser config file to correctly build the local-ic binaries
jtieri
changed the title
Reecepbcups
reviewed
Sep 13, 2024
|
todo: remove goreleaser |
Reecepbcups
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR revises the existing CI jobs to be conformant with our OSS guidelines.
All repo settings should also be in compliance with the OSS template now, EXCEPT for the required status checks. It seems like the GitHub workflow files need to me merged before it allows you to update the settings to use them.
The changes also include linter fixes that were able to be applied via
golangci-lint run ./... --fixEdit: we decided to stick with the existing workflow for releases due to issues we were having with the cross-arch compilation of
local-ic. We have decided that sinceinterchaintestis a library and that we are only building the binary forlocal-icit does not make sense to try and force a pattern that doesn't translate well.