Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links in PRs section of CONTRIBUTING.md #992

Merged
merged 1 commit into from
May 4, 2017

Conversation

usulpro
Copy link
Member

@usulpro usulpro commented May 4, 2017

CONTRIBUTING.md -> PRs section:

Issue: some of the links point to the labels which no longer exist

If our labels became more or less stable then let's update them

What I did

update links

How to test

check out new links.

@codecov
Copy link

codecov bot commented May 4, 2017

Codecov Report

Merging #992 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #992   +/-   ##
======================================
  Coverage    12.6%   12.6%           
======================================
  Files         192     192           
  Lines        4427    4427           
  Branches      707     707           
======================================
  Hits          558     558           
  Misses       3244    3244           
  Partials      625     625

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3558f8f...437ec61. Read the comment docs.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!!

@usulpro usulpro merged commit 0582fed into master May 4, 2017
@ndelangen ndelangen deleted the Contributing-patch-1 branch May 12, 2017 20:54
@shilman shilman added the misc label May 27, 2017
@ndelangen ndelangen added the cleanup Minor cleanup style change that won't show up in release changelog label May 27, 2017
Copy link

nx-cloud bot commented May 28, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 437ec61. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Minor cleanup style change that won't show up in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants