Fix webpack overriding && Add an example with local file dependencies #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for testing a non-linked example based on create-react-app
xavxyz
approved these changes
Apr 27, 2017
examples/test-cra/package.json
Outdated
| "version": "0.1.0", | ||
| "private": true, | ||
| "devDependencies": { | ||
| "@kadira/storybook": "file:../../packages/react-storybook", |
There was a problem hiding this comment.
so cool to have direct dependencies on the file system! 💯
There was a problem hiding this comment.
This is to be able to do an actual npm install without linking via lerna.
So when everything is installed flat things should work as expected.
| }, | ||
| "dependencies": { | ||
| "react": "^15.4.2", | ||
| "react-dom": "^15.4.2" |
There was a problem hiding this comment.
should we be on ^15.5.4 as the latest version published?
There was a problem hiding this comment.
Yeah for some reason npm-check-updates is no longer helping me with this 😞
but was not transpiring them correctly. MOVE jest cache directory to subdirectory `.cache`
ndelangen
changed the title
☁️ Nx Cloud ReportCI is running/has finished running commands for commit eb2eb55. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: -can't find it-
What I did
Fixed a few prepublish stuff
Fixed the babelconfig so it loads presets from included 'node_modules'
How to test
npm installcd examples/test-cranpm run storybookThis should result in a successful storybook being launched, and no messages in the terminal about presets not being loaded.