FIX brandImage staying storybook's logo when theme is created with brandTitle #6120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to null if not supplied also
Codecov Report
@@ Coverage Diff @@
## next #6120 +/- ##
==========================================
- Coverage 37.64% 37.64% -0.01%
==========================================
Files 642 642
Lines 9390 9391 +1
Branches 1365 1337 -28
==========================================
Hits 3535 3535
Misses 5295 5295
- Partials 560 561 +1
Continue to review full report at Codecov.
|
This was referenced Apr 10, 2019
shilman
added
the
patch:yes
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Apr 16, 2019
FIX brandImage staying storybook's logo when theme is created with brandTitle
| @@ -170,7 +170,7 @@ export const convert = (inherit: ThemeVars = lightThemeVars): Theme => { | |||
| brand: { | |||
| title: brandTitle, | |||
| url: brandUrl, | |||
| image: brandImage, | |||
| image: brandImage || brandTitle ? null : undefined, | |||
There was a problem hiding this comment.
Doesn't this make brandImage never used? Shouldn't this be
image: brandImage || (brandTitle ? null : undefined),
There was a problem hiding this comment.
@kennethtruong Mind doing a small PR for this?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #5866
What I did
CHANGE theme creation so when setting brandTitle, it sets brandImage to null if not supplied also.