Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3029 use @storybook/podda to fix npm engine version in podda #3033

Merged
merged 2 commits into from
Feb 20, 2018

Conversation

danielduan
Copy link
Member

Issue: fix #3029 podda npm engine requirements

What I did

published new version of podda under @storybook/podda to include an open PR that fixed the problem.

How to test

Install with npm > 3

@danielduan danielduan added compatibility with other tools ready patch:yes Bugfix & documentation PR that need to be picked to main branch labels Feb 20, 2018
@codecov
Copy link

codecov bot commented Feb 20, 2018

Codecov Report

Merging #3033 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3033   +/-   ##
=======================================
  Coverage   37.29%   37.29%           
=======================================
  Files         435      435           
  Lines        9435     9435           
  Branches      896      923   +27     
=======================================
  Hits         3519     3519           
+ Misses       5394     5333   -61     
- Partials      522      583   +61
Impacted Files Coverage Δ
lib/ui/src/index.js 13.33% <ø> (ø) ⬆️
app/polymer/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/react-native/src/preview/story_kind.js 0% <0%> (ø) ⬆️
lib/core/src/client/preview/config_api.js 46.55% <0%> (ø) ⬆️
addons/info/src/components/types/OneOf.js 61.11% <0%> (ø) ⬆️
addons/knobs/src/components/types/Array.js 34.14% <0%> (ø) ⬆️
app/angular/src/server/ts_config.js 38.09% <0%> (ø) ⬆️
addons/graphql/src/components/FullScreen/index.js 0% <0%> (ø) ⬆️
addons/jest/src/components/Indicator.js 0% <0%> (ø) ⬆️
addons/storyshots/src/rn/loader.js 53.33% <0%> (ø) ⬆️
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0404c7a...a18c768. Read the comment docs.

@Hypnosphi Hypnosphi merged commit b97b07b into master Feb 20, 2018
@Hypnosphi Hypnosphi deleted the dd/use-sb-podda branch February 20, 2018 09:26
@Hypnosphi Hypnosphi added patch:done Patch/release PRs already cherry-picked to main/release branch and removed patch:done Patch/release PRs already cherry-picked to main/release branch labels Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility with other tools patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants