Edited template of search box result item to fix overflow text in row #2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2419 +/- ##
==========================================
+ Coverage 16.65% 16.65% +<.01%
==========================================
Files 302 302
Lines 7770 7769 -1
Branches 776 776
==========================================
Hits 1294 1294
+ Misses 5879 5878 -1
Partials 597 597
Continue to review full report at Codecov.
|
Hypnosphi
requested changes
Dec 4, 2017
| <span style={{ float: 'right', opacity: 0.5 }}> | ||
| <div key={val.value} style={{ ...style, display: 'flex', justifyContent: 'space-between' }}> | ||
| <p style={{ margin: 0 }}>{val.value}</p> | ||
| <p style={{ opacity: 0.5, margin: 0, paddingLeft: 10 }}> |
There was a problem hiding this comment.
Let's add text-align: right here
There was a problem hiding this comment.
Thanks for reviewing !
Hypnosphi
approved these changes
Dec 5, 2017
This was referenced Dec 23, 2020
This was referenced Jan 12, 2022
This was referenced Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2183
What I did
How to test
Is this testable with jest or storyshots?