Render navigation and addons panels even when they are hidden #2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2336 +/- ##
=========================================
- Coverage 21.23% 21% -0.23%
=========================================
Files 283 283
Lines 6155 6150 -5
Branches 727 732 +5
=========================================
- Hits 1307 1292 -15
- Misses 4298 4302 +4
- Partials 550 556 +6
Continue to review full report at Codecov.
|
|
I love this! We have currently the issue with it with some in house addons! If you need some help/feedback do not hesitate 😄 |
ndelangen
reviewed
Nov 23, 2017
| expect(markup).toMatch(/LeftPanel/); | ||
| expect(markup).toMatch(/DownPanel/); | ||
| expect(markup).toMatch(/Preview/); | ||
| expect(wrap).toMatchSnapshot(); |
There was a problem hiding this comment.
This snapshot is huge, is there some sane way to deal with that, or is it inevitable?
There was a problem hiding this comment.
We can explicitly test the presence of particular styles instead
ndelangen
reviewed
Nov 23, 2017
| expect(markup).not.toMatch(/LeftPanel/); | ||
| expect(markup).not.toMatch(/DownPanel/); | ||
| expect(markup).toMatch(/Preview/); | ||
| expect(wrap).toMatchSnapshot(); |
ndelangen
reviewed
Nov 23, 2017
| expect(markup).not.toMatch(/LeftPanel/); | ||
| expect(markup).toMatch(/DownPanel/); | ||
| expect(markup).toMatch(/Preview/); | ||
| expect(wrap).toMatchSnapshot(); |
ndelangen
reviewed
Nov 23, 2017
| expect(markup).toMatch(/LeftPanel/); | ||
| expect(markup).not.toMatch(/DownPanel/); | ||
| expect(markup).toMatch(/Preview/); | ||
| expect(wrap).toMatchSnapshot(); |
ndelangen
approved these changes
Nov 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2280
Some addons (backgrounds, notes, probably others) send data from preview to addon panel when the former is rendered. The problem is that if the panel is hidden at that point, it's not actually rendered, so it will never receive that data.
What I did
Render addon panel with
display: nonewhen it should be hidden. Do the same with navigation panel just for consistency.How to test
Open backgrounds and notes examples in cra-kitchen-sink, toggle addon panel with
⌘ ⇧ D