Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Previews of deployed examples via Netlify #2304

Merged
merged 3 commits into from
Nov 14, 2017

Conversation

cheapsteak
Copy link
Member

@cheapsteak cheapsteak commented Nov 14, 2017

@codecov
Copy link

codecov bot commented Nov 14, 2017

Codecov Report

Merging #2304 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2304   +/-   ##
=======================================
  Coverage   21.19%   21.19%           
=======================================
  Files         283      283           
  Lines        6156     6156           
  Branches      728      722    -6     
=======================================
  Hits         1305     1305           
- Misses       4303     4315   +12     
+ Partials      548      536   -12
Impacted Files Coverage Δ
app/react/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/react/src/server/babel_config.js 0% <0%> (-77.42%) ⬇️
addons/knobs/src/components/types/Number.js 8.06% <0%> (ø) ⬆️
addons/a11y/src/components/Tabs.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/layout.js 12.5% <0%> (ø) ⬆️
addons/info/src/components/markdown/htags.js 30% <0%> (ø) ⬆️
.../src/manager/containers/CommentsPanel/dataStore.js 34.04% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/layout/dimensions.js 15.62% <0%> (ø) ⬆️
addons/knobs/src/components/PropField.js 10.63% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-start.js 0% <0%> (ø) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f772cd8...7bbf441. Read the comment docs.

@cheapsteak cheapsteak requested a review from a team November 14, 2017 03:14
@cheapsteak cheapsteak changed the title Netlify Netlify Deploy Previews Nov 14, 2017
Copy link
Member

@danielduan danielduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's awesome, thanks!

@danielduan danielduan merged commit e6b91af into storybookjs:master Nov 14, 2017
@cheapsteak cheapsteak deleted the netlify branch November 14, 2017 04:17
@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Nov 14, 2017
@ndelangen ndelangen changed the title Netlify Deploy Previews Add Previews of deployed examples via Netlify Nov 14, 2017
@danielduan danielduan mentioned this pull request Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants