Added create-react-native-app support #1117

shilman · 2017-05-24T13:37:29Z

What I did

detect CRNA projects
simplify RN and CRNA templates by consolidating app into single
index.js instead of index.ios.js and index.android.js
notify user of extra setup steps in CLI
document CRNA idiosyncrasies in README

Many thanks to @orta @tmeasday for helping me learn RN/CRNA basics!
And @inyono for rocking the post that inspired this PR.

How to test

yarn create react-native-app myapp
cd myapp
../path/to/storybook/lib/cli/bin/generate.js
# follow CLI / README instructions

1. detect CRNA projects 2. simplify RN and CRNA templates by consolidating app into single `index.js` instead of `index.ios.js` and `index.android.js` 3. notify user of extra setup steps in CLI 4. document CRNA idiosyncrasies in README

codecov · 2017-05-24T13:43:38Z

Codecov Report

Merging #1117 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1117      +/-   ##
==========================================
- Coverage   12.73%   12.69%   -0.05%     
==========================================
  Files         199      199              
  Lines        4475     4491      +16     
  Branches      711      714       +3     
==========================================
  Hits          570      570              
- Misses       3275     3288      +13     
- Partials      630      633       +3

Impacted Files	Coverage Δ
lib/cli/lib/project_types.js	`0% <ø> (ø)`	⬆️
lib/cli/bin/generate.js	`0% <0%> (ø)`	⬆️
lib/cli/lib/detect.js	`0% <0%> (ø)`	⬆️
addons/storyshots/src/test-bodies.js	`0% <0%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f908535...b7df231. Read the comment docs.

orta · 2017-05-24T13:51:43Z

app/react-native/readme.md

+module.exports = __DEV__ ? StorybookUI : App;
+```
+
+Alternatively, `StorybookUI` is simply a RN `View` component that can be embedded anywhere in your RN application, e.g. on a tab or within an admin screen.


This is a good coverage of options, nice work

orta · 2017-05-24T13:52:57Z

lib/cli/generators/REACT_NATIVE_SCRIPTS/index.js

+
+  if (!packageJson.dependencies['react-dom'] && !packageJson.devDependencies['react-dom']) {
+    packageJson.devDependencies['react-dom'] = '^15.5.4';
+  }


Nice one 👍

shilman · 2017-05-24T14:18:24Z

@inyono Mind reviewing this PR? I actually came up with the __DEV__ trick independently, but simply added it in the README docs. Let me know what you think. Happy to make changes!

inyono · 2017-05-24T16:47:57Z

Nice one! Will look over the PR at latest tomorrow :)

danielduan

I don't have a native environment to test but it looks good!

shilman · 2017-05-25T05:03:47Z

@danielduan if you're curious to test it out, it takes just 3 minutes using the test instructions above -- super easy setup!

codecov · 2017-05-25T12:12:26Z

Codecov Report

Merging #1117 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1117      +/-   ##
==========================================
- Coverage   12.89%   12.86%   -0.04%     
==========================================
  Files         199      199              
  Lines        4489     4501      +12     
  Branches      714      715       +1     
==========================================
  Hits          579      579              
- Misses       3278     3289      +11     
- Partials      632      633       +1

Impacted Files	Coverage Δ
lib/cli/lib/project_types.js	`0% <ø> (ø)`	⬆️
lib/cli/lib/detect.js	`0% <0%> (ø)`	⬆️
lib/cli/bin/generate.js	`0% <0%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93f17b2...d7ab0c2. Read the comment docs.

Add CRNA support

3e2673b

1. detect CRNA projects 2. simplify RN and CRNA templates by consolidating app into single `index.js` instead of `index.ios.js` and `index.android.js` 3. notify user of extra setup steps in CLI 4. document CRNA idiosyncrasies in README

shilman added the in progress label May 24, 2017

shilman requested review from tmeasday, thani-sh, danielduan and ndelangen May 24, 2017 13:38

orta approved these changes May 24, 2017

View reviewed changes

danielduan approved these changes May 24, 2017

View reviewed changes

ndelangen approved these changes May 25, 2017

View reviewed changes

shilman added 3 commits May 25, 2017 21:51

Fix linting and simplify code in CRNA generator

cfe5239

Fix linting err in CRNA script

fbb5a86

Remove unused variable in CRNA

b7df231

shilman and others added 2 commits May 26, 2017 01:58

Suppress lint error

01db559

Merge branch 'master' into 1115-crna-support

d7ab0c2

shilman merged commit 341e8a1 into master May 25, 2017

shilman removed the in progress label May 25, 2017

ndelangen deleted the 1115-crna-support branch May 25, 2017 16:12

shilman added the feature request label May 27, 2017

shilman changed the title ~~Added CRNA support~~ Added create-react-native-app support May 28, 2017

dependencies bot mentioned this pull request Oct 15, 2017

Update webpack-dev-server from 2.9.1 to 2.9.2 in examples/vue-kitchen-sink #2055

Merged

snyk-bot mentioned this pull request Nov 5, 2022

[Snyk] Fix for 1 vulnerabilities Bhanditz/storybook#98

Open

This was referenced Nov 5, 2022

[Snyk] Fix for 1 vulnerabilities adrianblynch/storybook#199

Open

[Snyk] Fix for 1 vulnerabilities adrianblynch/storybook#200

Open

adrukh mentioned this pull request Nov 5, 2022

[Snyk] Fix for 1 vulnerabilities adrukh/storybook#319

Open

snyk-bot mentioned this pull request Nov 5, 2022

[Snyk] Fix for 1 vulnerabilities aviadatsnyk/storybook#336

Open

adrianblynch mentioned this pull request Nov 5, 2022

[Snyk] Fix for 1 vulnerabilities adrianblynch/storybook#201

Open

Bhanditz mentioned this pull request Nov 5, 2022

[Snyk] Fix for 1 vulnerabilities Bhanditz/storybook#100

Open

This was referenced Dec 25, 2022

[Snyk] Fix for 1 vulnerabilities Bhanditz/storybook#107

Open

[Snyk] Fix for 1 vulnerabilities Bhanditz/storybook#108

Open

This was referenced Dec 25, 2022

[Snyk] Fix for 1 vulnerabilities adrianblynch/storybook#209

Open

[Snyk] Fix for 1 vulnerabilities adrianblynch/storybook#210

Open

adrukh mentioned this pull request Dec 26, 2022

[Snyk] Fix for 1 vulnerabilities adrukh/storybook#344

Open

adrianblynch mentioned this pull request Dec 26, 2022

[Snyk] Fix for 1 vulnerabilities adrianblynch/storybook#212

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added create-react-native-app support #1117

Added create-react-native-app support #1117

shilman commented May 24, 2017 •

edited

Loading

codecov bot commented May 24, 2017 •

edited

Loading

orta May 24, 2017

orta May 24, 2017

shilman commented May 24, 2017

inyono commented May 24, 2017

danielduan left a comment

shilman commented May 25, 2017

codecov bot commented May 25, 2017 •

edited

Loading

Added create-react-native-app support #1117

Added create-react-native-app support #1117

Conversation

shilman commented May 24, 2017 • edited Loading

What I did

How to test

codecov bot commented May 24, 2017 • edited Loading

Codecov Report

orta May 24, 2017

Choose a reason for hiding this comment

orta May 24, 2017

Choose a reason for hiding this comment

shilman commented May 24, 2017

inyono commented May 24, 2017

danielduan left a comment

Choose a reason for hiding this comment

shilman commented May 25, 2017

codecov bot commented May 25, 2017 • edited Loading

Codecov Report

shilman commented May 24, 2017 •

edited

Loading

codecov bot commented May 24, 2017 •

edited

Loading

codecov bot commented May 25, 2017 •

edited

Loading