Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix semi broken __docgenInfo integration in addon info #1030

Merged
merged 16 commits into from
May 19, 2017
Merged

Fix semi broken __docgenInfo integration in addon info #1030

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
b613d53
added version number.
May 10, 2017
a546a2e
working on getting more documentation.
May 10, 2017
5ac9286
added a post install script.
May 10, 2017
38a3c53
added code to support js documentation for adding descriptions to a c…
May 13, 2017
d61acd6
removed version number.
May 13, 2017
2ba6511
removed reference to `window` since it is not needed.
May 17, 2017
cd3ab0f
fixed code style problems.
May 18, 2017
a984acc
added version number.
May 10, 2017
edd6b69
working on getting more documentation.
May 10, 2017
7958923
added a post install script.
May 10, 2017
ad15e80
added code to support js documentation for adding descriptions to a c…
May 13, 2017
8dc1369
removed version number.
May 13, 2017
622dadb
removed reference to `window` since it is not needed.
May 17, 2017
ad0fcfe
fixed code style problems.
May 18, 2017
3e7bc3c
Merge branch 'master' of github.com:bigassdragon/storybook
May 19, 2017
d08b51b
Merge branch 'master' into master
ndelangen May 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
},
"scripts": {
"bootstrap": "lerna bootstrap",
"postinstall": "lerna bootstrap --hoist",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because a few reason we don't do this, and instead bootstrap manually.

  1. For some CI tasks bootstrapping is unnecessary, but installing is. Bootstrapping is rather slow.
  2. We do npm install in examples, this will cause the postinstall to re-run, causing a lot of unnecessary delay.
  3. When adding a root dependency for development, bootstrapping is not needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this postinstall hook?

"lint": "eslint .",
"test": "jest",
"test:watch": "npm test -- --watch",
Expand Down