Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): version bump to fix release PR loop #2556

Closed
wants to merge 4 commits into from

Conversation

brendarearden
Copy link
Contributor

@brendarearden brendarearden commented Jul 3, 2024

Addresses STOP-537

Summary

Doing a general bump of versions to see if that resolves the master branch getting stuck in a release PR loop for the root project per this suggestion: https://stackoverflow.com/questions/75806309/release-please-creates-the-same-release-pr-after-merge. We have been seeing the same PR get created with a version bump over and over. If this does not work, we will remove the root from the release please configuration.

Changes:

  • Cleaned up change log files to be the correct changes for the version
  • Reverted the root version to match the sub-packages

Checklist

  • The basics
    • I tested these changes manually in my local or dev environment
  • Tests
    • Added or updated
    • N/A
  • Event Tracking
    • I added event tracking and followed the event tracking guidelines
    • N/A
  • Error Reporting
    • I reported errors and followed the error reporting guidelines
    • N/A

@brendarearden brendarearden requested a review from a team as a code owner July 3, 2024 19:29
@brendarearden brendarearden requested review from kaylachun and removed request for a team July 3, 2024 19:29
@brendarearden brendarearden requested a review from a team as a code owner July 3, 2024 21:41
@brendarearden
Copy link
Contributor Author

brendarearden commented Jul 3, 2024

I am not super convinced that bumping the versions so they are all the same will work. I think the issue will eventually come up again because here is the history:

There must be some bug with the linked-versions config. But it might be worth a try! If it doesn't fix it, #2558 this can be merged to resolve it.

@brendarearden
Copy link
Contributor Author

Not the route we want to go in order to resolve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant