Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ParserConfiguration class hierarchy #729

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

TamasPergerDWP
Copy link
Contributor

Resolve #728

First draft MR -- happy to receive feedback or ideas to improve.

@stleary
Copy link
Owner

stleary commented Feb 25, 2023

What problem does this code solve?
ParserConfiguration classes should be refactored for common properties and behavior.

Risks
Low

Changes to the API?
No

Will this require a new release?
Yes

Should the documentation be updated?
No

Does it break the unit tests?
No, unit tests were added

Was any code refactored in this commit?
No

Review status
APPROVED

@stleary
Copy link
Owner

stleary commented Feb 25, 2023

Starting 3-day comment window.

@stleary stleary changed the title Draft: refactor: introduce ParserConfiguration class hierarchy Refactor ParserConfiguration class hierarchy Feb 25, 2023
@TamasPergerDWP TamasPergerDWP marked this pull request as ready for review February 27, 2023 09:40
@stleary stleary merged commit 45bcba5 into stleary:master Feb 28, 2023
@TamasPergerDWP TamasPergerDWP deleted the f-parserconfig branch February 28, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify parser configuration classes in a hierarchy
3 participants