Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer unsynchronized StringBuilder #474

Merged
merged 1 commit into from
Jul 26, 2019
Merged

Conversation

gaul
Copy link
Contributor

@gaul gaul commented Jul 23, 2019

StringBuffer provides unneeded synchronization. Found via
error-prone.

StringBuffer provides unneeded synchronization.  Found via
error-prone.
@stleary
Copy link
Owner

stleary commented Jul 24, 2019

What problem does this code solve?
Replaces an internally used inefficient StringBuffer class

Risks
Low

Changes to the API?
No

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No, and additional unit tests are not needed.

Was any code refactored in this commit?
No

Review status
Approved, starting 3 day comment window

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants