Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix double ctor in JSONWriter #417

Merged
merged 1 commit into from
May 16, 2018
Merged

fix double ctor in JSONWriter #417

merged 1 commit into from
May 16, 2018

Conversation

stleary
Copy link
Owner

@stleary stleary commented May 3, 2018

This replaces #414 which had a coding standards error (tab instead of spaces). Also just noticed we don't have any coding standards published. Will update the Wiki.

@stleary
Copy link
Owner Author

stleary commented May 3, 2018

What problem does this code solve?
The Double ctor is deprecated, so changed to with the recommended replacement method. This appears to only be an OpenJDK issue, but no harm in maintaining compatibility. For more information, see:
https://bugs.openjdk.java.net/browse/JDK-8176335.
This code was originally submitted in #414 but that change used a tab char, which has been corrected.

Risks
Low

Changes to the API?
No

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No. Confirmed that the existing tests already provide coverage for the modified line.

Was any code refactored in this commit?
No

Review status
APPROVED (#414 approval transferred to this pull request) Starting 3 day comment window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant