Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale tests for non en keys #64

Merged
merged 2 commits into from
Feb 20, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@ apply plugin: 'java'
apply plugin: 'eclipse'
apply plugin: 'jacoco'

tasks.withType(JavaCompile) {
// this subproject requires -parameters option
options.compilerArgs << '-parameters'
options.encoding = 'UTF-8'
}

sourceSets {
// Uncomment main if you have merged JSON-Java and JSON-Java-unit-test code
main
Expand Down
55 changes: 55 additions & 0 deletions src/test/java/org/json/junit/JSONObjectLocaleTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
package org.json.junit;

import static org.junit.Assert.*;

import java.util.*;

import org.json.*;
import org.junit.*;

/**
* Note: This file is saved as UTF-8. Do not save as ASCII or the tests will
* fail.
*
*/
public class JSONObjectLocaleTest {
/**
* JSONObject built from a bean with locale-specific keys.
* In the Turkish alphabet, there are 2 versions of the letter "i".
* 'eh' I ı (dotless i)
* 'ee' İ i (dotted i)
* A problem can occur when parsing the public get methods for a bean.
* If the method starts with getI... then the key name will be lowercased
* to 'i' in English, and 'ı' in Turkish.
* We want the keys to be consistent regardless of locale, so JSON-Java
* lowercase operations are made to be locale-neutral by specifying
* Locale.ROOT. This causes 'I' to be universally lowercased to 'i'
* regardless of the locale currently in effect.
*/
@Test
public void jsonObjectByLocaleBean() {

MyLocaleBean myLocaleBean = new MyLocaleBean();

/**
* This is just the control case which happens when the locale.ROOT
* lowercasing behavior is the same as the current locale.
*/
Locale.setDefault(new Locale("en"));
JSONObject jsonen = new JSONObject(myLocaleBean);
assertEquals("expected size 2, found: " +jsonen.length(), 2, jsonen.length());
assertEquals("expected jsonen[i] == beanI", "beanI", jsonen.getString("i"));
assertEquals("expected jsonen[id] == beanId", "beanId", jsonen.getString("id"));

/**
* Without the JSON-Java change, these keys would be stored internally as
* starting with the letter, 'ı' (dotless i), since the lowercasing of
* the getI and getId keys would be specific to the Turkish locale.
*/
Locale.setDefault(new Locale("tr"));
JSONObject jsontr = new JSONObject(myLocaleBean);
assertEquals("expected size 2, found: " +jsontr.length(), 2, jsontr.length());
assertEquals("expected jsontr[i] == beanI", "beanI", jsontr.getString("i"));
assertEquals("expected jsontr[id] == beanId", "beanId", jsontr.getString("id"));
}
}
1 change: 1 addition & 0 deletions src/test/java/org/json/junit/JunitTestSuite.java
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
HTTPTest.class,
JSONStringerTest.class,
JSONObjectTest.class,
JSONObjectLocaleTest.class,
JSONArrayTest.class,
EnumTest.class,
JSONPointerTest.class,
Expand Down
12 changes: 12 additions & 0 deletions src/test/java/org/json/junit/MyLocaleBean.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package org.json.junit;

public class MyLocaleBean {
private final String id = "beanId";
private final String i = "beanI";
public String getId() {
return id;
}
public String getI() {
return i;
}
}