448 make public example #450
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #450 +/- ##
=========================================
Coverage ? 92.13%
=========================================
Files ? 85
Lines ? 13824
Branches ? 0
=========================================
Hits ? 12737
Misses ? 1087
Partials ? 0 ☔ View full report in Codecov by Sentry. |
arporter
requested changes
Oct 7, 2024
|
|
||
| create_dependencies.py | ||
| ^^^^^^^^^^^^^^^^^^^^^^ | ||
| This file analysis the dependencies between a set of Fortran files, based on |
| that will read this file, execute the kernel, and compare the results with | ||
| the original results. | ||
|
|
||
| Since PSyclone will follow call tree, the code must be able to read even |
| run time of the script, it will use these values as default values in the | ||
| makefile. But by setting these environment variables when running ``make``, | ||
| these defaults can always be overwritten. The Makefile also has a ``clean`` | ||
| target, which will remove all ``.mod``, object, and the program file (if |
There was a problem hiding this comment.
Good stuff, thanks for adding this Joerg.
| @@ -33,17 +33,22 @@ | |||
| # ------------------------------------------------------------------------------ | |||
| # Author: J. Henrichs, Bureau of Meteorology | |||
|
|
|||
There was a problem hiding this comment.
Comment please, e.g. "Makefile driver to test the various examples"
| # ----------------------------------------------------------------------------- | ||
| # BSD 3-Clause License | ||
| # | ||
| # Copyright (c) 2020, Science and Technology Facilities Council. |
There was a problem hiding this comment.
Oh my life, this has been a while! Apologies. Could update to 2020-24 now?
| # ------------------------------------------------------------------------------ | ||
| # Author: Joerg Henrichs, Bureau of Meteorology | ||
|
|
||
| """This file contains an fparser script that parses Fortran files |
There was a problem hiding this comment.
This docstring needs changing (and possibly explains the 2020 date ;-) ).
| all_nodes = list(walk(parse_tree, Attr_Spec)) | ||
| for node in all_nodes: | ||
| if str(node) == "PROTECTED": | ||
| # This is a tuple, so we can't simple remove the attribute |
| for node in all_nodes: | ||
| if str(node) == "PROTECTED": | ||
| # This is a tuple, so we can't simple remove the attribute | ||
| node.parent.items = tuple(i for i in node.parent.items if i is not node) |
arporter
added
reviewed with actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a script that removes all private and protected attributes (which is used in PSyclone's kernel extraction).
Added a chapter explaining the examples to the manual, added tests for examples (triggered in CI), and added me as author.