Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: roll back default change of kbins #69

Merged
merged 7 commits into from
Aug 5, 2024

Conversation

steven-murray
Copy link
Owner

Rolls back the change to the default kbins produced in get_power. Now the default is what it was before, but with a warning saying that this will change in the future.

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.95%. Comparing base (bcf2573) to head (85d15d0).

Files Patch % Lines
src/powerbox/tools.py 96.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
+ Coverage   92.88%   92.95%   +0.07%     
==========================================
  Files           5        5              
  Lines         576      582       +6     
==========================================
+ Hits          535      541       +6     
  Misses         41       41              
Flag Coverage Δ
unittests 92.95% <96.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@DanielaBreitman DanielaBreitman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@DanielaBreitman DanielaBreitman merged commit a01718e into main Aug 5, 2024
27 checks passed
@DanielaBreitman DanielaBreitman deleted the rollback-default-krange branch August 5, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants