Skip to content

refactor DataSource #1856

refactor DataSource

refactor DataSource #1856

GitHub Actions / checkstyle completed Aug 24, 2024 in 0s

reviewdog [checkstyle] report

reported by reviewdog 🐶

Findings (1)

src/main/java/de/rwth/idsg/steve/repository/impl/GenericRepositoryImpl.java|76 col 90| '+' should be on a new line.

Filtered Findings (268)

src/main/java/de/rwth/idsg/steve/service/ChargePointService16_Client.java|51 col 14| Name 'ChargePointService16_Client' must match pattern '^[A-Z][a-zA-Z0-9]$'.
src/main/java/de/rwth/idsg/steve/service/ChargePointService16_Client.java|95| Line is longer than 120 characters (found 122).
src/main/java/de/rwth/idsg/steve/service/ChargePointService16_Client.java|128| Line is longer than 120 characters (found 132).
src/main/java/de/rwth/idsg/steve/service/ChargePointService12_Client.java|56 col 14| Name 'ChargePointService12_Client' must match pattern '^[A-Z][a-zA-Z0-9]
$'.
src/main/java/de/rwth/idsg/steve/service/ChargePointService12_Client.java|58 col 51| Variable 'executorService' must be private and have accessor methods.
src/main/java/de/rwth/idsg/steve/service/ChargePointService12_Client.java|59 col 36| Variable 'taskStore' must be private and have accessor methods.
src/main/java/de/rwth/idsg/steve/service/OcppTagService.java|25 col 8| Unused import - de.rwth.idsg.steve.SteveException.
src/main/java/de/rwth/idsg/steve/service/OcppTagService.java|108| Line is longer than 120 characters (found 121).
src/main/java/de/rwth/idsg/steve/service/OcppTagService.java|158| Line is longer than 120 characters (found 126).
src/main/java/de/rwth/idsg/steve/service/ChargePointService15_Client.java|55 col 14| Name 'ChargePointService15_Client' must match pattern '^[A-Z][a-zA-Z0-9]$'.
src/main/java/de/rwth/idsg/steve/service/ChargePointService15_Client.java|57 col 41| Variable 'ocppTagService' must be private and have accessor methods.
src/main/java/de/rwth/idsg/steve/service/ChargePointService15_Client.java|58 col 48| Variable 'reservationRepository' must be private and have accessor methods.
src/main/java/de/rwth/idsg/steve/service/NotificationService.java|65| Line is longer than 120 characters (found 171).
src/main/java/de/rwth/idsg/steve/service/NotificationService.java|101| Line is longer than 120 characters (found 148).
src/main/java/de/rwth/idsg/steve/service/NotificationService.java|113| Line is longer than 120 characters (found 226).
src/main/java/de/rwth/idsg/steve/service/NotificationService.java|124| Line is longer than 120 characters (found 175).
src/main/java/de/rwth/idsg/steve/service/ChargePointHelperService.java|83| Line is longer than 120 characters (found 123).
src/main/java/de/rwth/idsg/steve/service/ChargePointHelperService.java|116| Line is longer than 120 characters (found 122).
src/main/java/de/rwth/idsg/steve/service/ChargePointHelperService.java|151| Line is longer than 120 characters (found 121).
src/main/java/de/rwth/idsg/steve/service/ChargePointHelperService.java|162| Line is longer than 120 characters (found 146).
src/main/java/de/rwth/idsg/steve/service/ChargePointHelperService.java|165| Line is longer than 120 characters (found 123).
src/main/java/de/rwth/idsg/steve/service/ChargePointHelperService.java|167| Line is longer than 120 characters (found 123).
src/main/java/de/rwth/idsg/steve/service/ChargePointHelperService.java|169| Line is longer than 120 characters (found 123).
src/main/java/de/rwth/idsg/steve/service/ChargePointHelperService.java|217| Line is longer than 120 characters (found 125).
src/main/java/de/rwth/idsg/steve/service/ChargePointHelperService.java|224| Line is longer than 120 characters (found 131).
src/main/java/de/rwth/idsg/steve/service/ChargePointHelperService.java|229 col 13| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/service/ChargePointHelperService.java|230| Line is longer than 120 characters (found 122).
src/main/java/de/rwth/idsg/steve/service/CentralSystemService16_Service.java|72 col 14| Name 'CentralSystemService16_Service' must match pattern '^[A-Z][a-zA-Z0-9]
$'.
src/main/java/de/rwth/idsg/steve/service/CentralSystemService16_Service.java|93| Line is longer than 120 characters (found 129).
src/main/java/de/rwth/idsg/steve/service/CentralSystemService16_Service.java|129 col 58| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/service/CentralSystemService16_Service.java|205 col 54| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/service/WebUserService.java|161 col 39| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/service/WebUserService.java|164 col 44| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/web/dto/EndpointInfo.java|38| Line is longer than 120 characters (found 121).
src/main/java/de/rwth/idsg/steve/web/dto/EndpointInfo.java|39| Line is longer than 120 characters (found 151).
src/main/java/de/rwth/idsg/steve/web/dto/EndpointInfo.java|41 col 5| Class ItemsWithInfo should be declared as final.
src/main/java/de/rwth/idsg/steve/web/dto/OcppTagQueryForm.java|112 col 23| '(' is preceded with whitespace.
src/main/java/de/rwth/idsg/steve/web/dto/ChargingProfileForm.java|125 col 34| Name 'defaultNumberPhases' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.
src/main/java/de/rwth/idsg/steve/web/dto/QueryForm.java|45| Line is longer than 120 characters (found 142).
src/main/java/de/rwth/idsg/steve/web/dto/QueryForm.java|48| Line is longer than 120 characters (found 143).
src/main/java/de/rwth/idsg/steve/web/dto/ocpp/ClearChargingProfileParams.java|45| Line is longer than 120 characters (found 130).
src/main/java/de/rwth/idsg/steve/web/dto/ocpp/SendLocalListParams.java|52| Line is longer than 120 characters (found 126).
src/main/java/de/rwth/idsg/steve/web/dto/TransactionQueryForm.java|49| Line is longer than 120 characters (found 170).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|64| Line is longer than 120 characters (found 185).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|65| Line is longer than 120 characters (found 186).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|66| Line is longer than 120 characters (found 195).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|80| Line is longer than 120 characters (found 185).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|81| Line is longer than 120 characters (found 186).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|82| Line is longer than 120 characters (found 183).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|83| Line is longer than 120 characters (found 195).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|97| Line is longer than 120 characters (found 185).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|98| Line is longer than 120 characters (found 186).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|99| Line is longer than 120 characters (found 194).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|100| Line is longer than 120 characters (found 183).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|101| Line is longer than 120 characters (found 195).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|118| Line is longer than 120 characters (found 185).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|119| Line is longer than 120 characters (found 186).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|120| Line is longer than 120 characters (found 183).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|121| Line is longer than 120 characters (found 195).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|125| Line is longer than 120 characters (found 122).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|138| Line is longer than 120 characters (found 185).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|139| Line is longer than 120 characters (found 186).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|140| Line is longer than 120 characters (found 183).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|141| Line is longer than 120 characters (found 195).
src/main/java/de/rwth/idsg/steve/web/api/ApiControllerAdvice.java|72| Line is longer than 120 characters (found 122).
src/main/java/de/rwth/idsg/steve/web/api/ApiControllerAdvice.java|88| Line is longer than 120 characters (found 142).
src/main/java/de/rwth/idsg/steve/web/api/TransactionsRestController.java|55| Line is longer than 120 characters (found 185).
src/main/java/de/rwth/idsg/steve/web/api/TransactionsRestController.java|56| Line is longer than 120 characters (found 186).
src/main/java/de/rwth/idsg/steve/web/api/TransactionsRestController.java|57| Line is longer than 120 characters (found 195).
src/main/java/de/rwth/idsg/steve/web/validation/ChargeBoxIdValidator.java|65 col 55| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/web/validation/IdTag.java|39| Line is longer than 120 characters (found 141).
src/main/java/de/rwth/idsg/steve/web/controller/ChargePointsController.java|55 col 48| Variable 'chargePointRepository' must be private and have accessor methods.
src/main/java/de/rwth/idsg/steve/web/controller/ChargePointsController.java|56 col 51| Variable 'chargePointHelperService' must be private and have accessor methods.
src/main/java/de/rwth/idsg/steve/web/controller/ChargePointsController.java|60| Line is longer than 120 characters (found 133).
src/main/java/de/rwth/idsg/steve/web/controller/ChargePointsController.java|60 col 39| Name 'upToOcpp15RegistrationStatusList' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.
src/main/java/de/rwth/idsg/steve/web/controller/ChargePointsController.java|61| Line is longer than 120 characters (found 128).
src/main/java/de/rwth/idsg/steve/web/controller/ChargePointsController.java|64| Line is longer than 120 characters (found 129).
src/main/java/de/rwth/idsg/steve/web/controller/ChargePointsController.java|64 col 39| Name 'ocpp16RegistrationStatusList' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.
src/main/java/de/rwth/idsg/steve/web/controller/ChargePointsController.java|65| Line is longer than 120 characters (found 124).
src/main/java/de/rwth/idsg/steve/web/controller/Ocpp16Controller.java|109| Line is longer than 120 characters (found 121).
src/main/java/de/rwth/idsg/steve/web/controller/Ocpp12Controller.java|58 col 51| Variable 'chargePointHelperService' must be private and have accessor methods.
src/main/java/de/rwth/idsg/steve/web/controller/Ocpp12Controller.java|59 col 41| Variable 'ocppTagService' must be private and have accessor methods.
src/main/java/de/rwth/idsg/steve/web/controller/OcppTagsController.java|39 col 8| Unused import - java.util.List.
src/main/java/de/rwth/idsg/steve/web/controller/OcppTagsController.java|49 col 41| Variable 'ocppTagService' must be private and have accessor methods.
src/main/java/de/rwth/idsg/steve/web/LocalDateTimeEditor.java|28 col 8| Unused import - org.springframework.security.core.parameters.P.
src/main/java/de/rwth/idsg/steve/repository/impl/ReservationRepositoryImpl.java|163| Line is longer than 120 characters (found 122).
src/main/java/de/rwth/idsg/steve/repository/impl/ReservationRepositoryImpl.java|174 col 116| '+' should be on a new line.
src/main/java/de/rwth/idsg/steve/repository/impl/ChargePointRepositoryImpl.java|91| Line is longer than 120 characters (found 141).
src/main/java/de/rwth/idsg/steve/repository/impl/ChargePointRepositoryImpl.java|93 col 13| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/repository/impl/ChargePointRepositoryImpl.java|268| Line is longer than 120 characters (found 129).
src/main/java/de/rwth/idsg/steve/repository/impl/ChargePointRepositoryImpl.java|268 col 77| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/repository/impl/ChargePointRepositoryImpl.java|353| Line is longer than 120 characters (found 132).
src/main/java/de/rwth/idsg/steve/repository/impl/ChargePointRepositoryImpl.java|368| Line is longer than 120 characters (found 125).
src/main/java/de/rwth/idsg/steve/repository/impl/OcppTagRepositoryImpl.java|87| Line is longer than 120 characters (found 123).
src/main/java/de/rwth/idsg/steve/repository/impl/OcppTagRepositoryImpl.java|111| Line is longer than 120 characters (found 124).
src/main/java/de/rwth/idsg/steve/repository/impl/OcppTagRepositoryImpl.java|256| Line is longer than 120 characters (found 142).
src/main/java/de/rwth/idsg/steve/repository/impl/OcppTagRepositoryImpl.java|258| Line is longer than 120 characters (found 126).
src/main/java/de/rwth/idsg/steve/repository/impl/OcppServerRepositoryImpl.java|169| Line is longer than 120 characters (found 124).
src/main/java/de/rwth/idsg/steve/repository/impl/OcppServerRepositoryImpl.java|307 col 23| Variable 'existsAlready' must be private and have accessor methods.
src/main/java/de/rwth/idsg/steve/repository/impl/OcppServerRepositoryImpl.java|308 col 19| Variable 'transactionId' must be private and have accessor methods.
src/main/java/de/rwth/idsg/steve/repository/impl/OcppServerRepositoryImpl.java|443 col 85| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/repository/impl/OcppServerRepositoryImpl.java|444 col 76| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/repository/impl/OcppServerRepositoryImpl.java|445 col 82| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/repository/impl/OcppServerRepositoryImpl.java|446 col 80| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/repository/impl/OcppServerRepositoryImpl.java|447 col 72| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/repository/impl/OcppServerRepositoryImpl.java|448 col 74| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/repository/impl/UserRepositoryImpl.java|166| Line is longer than 120 characters (found 127).
src/main/java/de/rwth/idsg/steve/repository/impl/TransactionRepositoryImpl.java|104| Line is longer than 120 characters (found 139).
src/main/java/de/rwth/idsg/steve/repository/impl/TransactionRepositoryImpl.java|147| Line is longer than 120 characters (found 127).
src/main/java/de/rwth/idsg/steve/repository/impl/TransactionRepositoryImpl.java|251| Line is longer than 120 characters (found 148).
src/main/java/de/rwth/idsg/steve/repository/impl/TransactionRepositoryImpl.java|337| Line is longer than 120 characters (found 214).
src/main/java/de/rwth/idsg/steve/repository/impl/TransactionRepositoryImpl.java|339| Line is longer than 120 characters (found 167).
src/main/java/de/rwth/idsg/steve/repository/impl/ChargingProfileRepositoryImpl.java|106| Line is longer than 120 characters (found 126).
src/main/java/de/rwth/idsg/steve/repository/impl/ChargingProfileRepositoryImpl.java|106 col 64| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/repository/impl/ChargingProfileRepositoryImpl.java|122| Line is longer than 120 characters (found 146).
src/main/java/de/rwth/idsg/steve/repository/impl/ChargingProfileRepositoryImpl.java|122 col 60| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/repository/impl/ChargingProfileRepositoryImpl.java|124| Line is longer than 120 characters (found 133).
src/main/java/de/rwth/idsg/steve/repository/impl/ChargingProfileRepositoryImpl.java|124 col 66| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/repository/impl/ChargingProfileRepositoryImpl.java|277| Line is longer than 120 characters (found 124).
src/main/java/de/rwth/idsg/steve/repository/impl/ChargingProfileRepositoryImpl.java|279| Line is longer than 120 characters (found 149).
src/main/java/de/rwth/idsg/steve/repository/impl/ChargingProfileRepositoryImpl.java|279 col 108| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/repository/impl/ChargingProfileRepositoryImpl.java|283| Line is longer than 120 characters (found 123).
src/main/java/de/rwth/idsg/steve/repository/impl/ChargingProfileRepositoryImpl.java|313| Line is longer than 120 characters (found 133).
src/main/java/de/rwth/idsg/steve/repository/impl/ChargingProfileRepositoryImpl.java|313 col 92| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/repository/impl/ChargingProfileRepositoryImpl.java|359| Line is longer than 120 characters (found 132).
src/main/java/de/rwth/idsg/steve/repository/ReservationStatus.java|31| Line is longer than 120 characters (found 122).
src/main/java/de/rwth/idsg/steve/repository/ChargePointRepository.java|42| Line is longer than 120 characters (found 133).
src/main/java/de/rwth/idsg/steve/utils/OcppTagActivityRecordUtils.java|26 col 1| Utility classes should not have a public or default constructor.
src/main/java/de/rwth/idsg/steve/utils/DateTimeUtils.java|37 col 1| Utility classes should not have a public or default constructor.
src/main/java/de/rwth/idsg/steve/utils/StringUtils.java|40 col 1| Utility classes should not have a public or default constructor.
src/main/java/de/rwth/idsg/steve/utils/CustomDSL.java|39 col 1| Utility classes should not have a public or default constructor.
src/main/java/de/rwth/idsg/steve/utils/CustomDSL.java|43| Line is longer than 120 characters (found 128).
src/main/java/de/rwth/idsg/steve/utils/PropertiesFileLoader.java|53 col 113| '+' should be on a new line.
src/main/java/de/rwth/idsg/steve/utils/PropertiesFileLoader.java|69 col 33| ',' is not followed by whitespace.
src/main/java/de/rwth/idsg/steve/utils/PropertiesFileLoader.java|73 col 33| ',' is not followed by whitespace.
src/main/java/de/rwth/idsg/steve/utils/CountryCodesProvider.java|36 col 1| Utility classes should not have a public or default constructor.
src/main/java/de/rwth/idsg/steve/utils/InternetChecker.java|37 col 1| Utility classes should not have a public or default constructor.
src/main/java/de/rwth/idsg/steve/utils/ControllerHelper.java|23 col 8| Unused import - lombok.experimental.UtilityClass.
src/main/java/de/rwth/idsg/steve/utils/ControllerHelper.java|35 col 1| Utility classes should not have a public or default constructor.
src/main/java/de/rwth/idsg/steve/utils/TransactionStopServiceHelper.java|27 col 1| Utility classes should not have a public or default constructor.
src/main/java/de/rwth/idsg/steve/utils/mapper/UserFormMapper.java|33 col 1| Utility classes should not have a public or default constructor.
src/main/java/de/rwth/idsg/steve/utils/mapper/AddressMapper.java|31 col 1| Utility classes should not have a public or default constructor.
src/main/java/de/rwth/idsg/steve/utils/mapper/ChargingProfileDetailsMapper.java|42 col 1| Utility classes should not have a public or default constructor.
src/main/java/de/rwth/idsg/steve/utils/mapper/ChargingProfileDetailsMapper.java|56| Line is longer than 120 characters (found 135).
src/main/java/de/rwth/idsg/steve/utils/mapper/ChargingProfileDetailsMapper.java|56 col 68| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/utils/mapper/OcppTagFormMapper.java|32 col 1| Utility classes should not have a public or default constructor.
src/main/java/de/rwth/idsg/steve/utils/mapper/ChargePointDetailsMapper.java|31 col 1| Utility classes should not have a public or default constructor.
src/main/java/de/rwth/idsg/steve/utils/ConnectorStatusCountFilter.java|37 col 1| Utility classes should not have a public or default constructor.
src/main/java/de/rwth/idsg/steve/utils/ConnectorStatusFilter.java|37 col 1| Utility classes should not have a public or default constructor.
src/main/java/de/rwth/idsg/steve/Application.java|45| Line is longer than 120 characters (found 126).
... (Too many findings. Dropped some findings)

Annotations

Check failure on line 76 in src/main/java/de/rwth/idsg/steve/repository/impl/GenericRepositoryImpl.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/main/java/de/rwth/idsg/steve/repository/impl/GenericRepositoryImpl.java#L76 <com.puppycrawl.tools.checkstyle.checks.whitespace.OperatorWrapCheck>

'+' should be on a new line.
Raw output
/github/workspace/./src/main/java/de/rwth/idsg/steve/repository/impl/GenericRepositoryImpl.java:76:90: error: '+' should be on a new line. (com.puppycrawl.tools.checkstyle.checks.whitespace.OperatorWrapCheck)